Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): removes redundant rules from tslint.json #5783

Merged
merged 1 commit into from
May 4, 2017

Conversation

dave11mj
Copy link
Contributor

Fixes #5755

@hansl
Copy link
Contributor

hansl commented Mar 31, 2017

Could you explain more how these rules were redundant?

@dave11mj dave11mj force-pushed the remove-tslint-redundant-rules branch from 02e0656 to 59aef3f Compare April 1, 2017 00:49
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 1, 2017
@dave11mj dave11mj force-pushed the remove-tslint-redundant-rules branch from 59aef3f to 03234d8 Compare April 1, 2017 00:58
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 1, 2017
@dave11mj
Copy link
Contributor Author

dave11mj commented Apr 1, 2017

@hansl sorry about the hiccup while trying to update the commit, I'll update the issue #5755 with additional testing instructions. But the tldr; is if you create two const or let like

const hello = 'hello';
const hello = 'hi';

The linter returns valid. As mentioned in the docs

This rule is only useful when using the var keyword

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR, I read through the original issue and think it's solid.

@filipesilva filipesilva merged commit d90292e into angular:master May 4, 2017
@dave11mj dave11mj deleted the remove-tslint-redundant-rules branch May 4, 2017 19:10
filipesilva pushed a commit to filipesilva/angular-cli that referenced this pull request May 9, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants