Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Please add a @NgModule annotation" error in 1.0.4. Works in 1.0.3. #6429

Closed
mderoche opened this issue May 23, 2017 · 5 comments
Closed

"Please add a @NgModule annotation" error in 1.0.4. Works in 1.0.3. #6429

mderoche opened this issue May 23, 2017 · 5 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity3: broken

Comments

@mderoche
Copy link

mderoche commented May 23, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.4
node: 6.10.0
os: darwin x64
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/router: 4.1.3
@angular/cli: 1.0.4
@angular/compiler-cli: 4.1.3

Repro steps.

  1. Clone this sample module, which allegedly uses the current recommended Angular package format: https://github.com/jasonaden/simple-ui-lib
  2. Create new test app with: ng new testApp
  3. Build simple-ui-lib with sh build.sh
  4. npm link simple-ui-lib's /dist
  5. Go to the testApp and npm link simple-ui-lib
  6. Import the module in testApp: import { BoxModule } from 'simple-ui-lib';
  7. Add BoxModule to the imports in testApp's app module

The log given by the failure.

compiler.es5.js:1540 Uncaught Error: Unexpected value 'BoxModule' imported by the module 'AppModule'. Please add a @NgModule annotation.
at syntaxError (http://localhost:4200/vendor.bundle.js:29714:34)
at http://localhost:4200/vendor.bundle.js:42668:44
at Array.forEach (native)
at CompileMetadataResolver.getNgModuleMetadata (http://localhost:4200/vendor.bundle.js:42651:49)
at JitCompiler._loadModules (http://localhost:4200/vendor.bundle.js:53804:66)
at JitCompiler.compileModuleAndComponents (http://localhost:4200/vendor.bundle.js:53763:52)
at JitCompiler.compileModuleAsync (http://localhost:4200/vendor.bundle.js:53725:23)
at PlatformRef
.bootstrapModuleWithZone (http://localhost:4200/vendor.bundle.js:5731:25)
at PlatformRef
.bootstrapModule (http://localhost:4200/vendor.bundle.js:5717:21)
at Object.116 (http://localhost:4200/main.bundle.js:117:124)

Desired functionality.

I'd assume that since this error spawns from both the recommended package setup, and a default new CLI application, that it should run with no errors right out of the box.

Mention any other details that might be useful.

This works in 1.0.3, but breaks in 1.0.4. (Broken in 1.1.0-rc.0 as well.) Not sure if this is actually a bug, or some change in how Angular CLI expects outside modules to be built.

@Brocco Brocco assigned Brocco and filipesilva and unassigned Brocco May 23, 2017
@Brocco Brocco added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity3: broken labels May 23, 2017
@clydin
Copy link
Member

clydin commented May 23, 2017

For details on using a linked library, please see this new developer story: https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/linked-library.md

@filipesilva
Copy link
Contributor

Closing as answered by @clydin, guidance can be found at that link.

@TheDevelolper
Copy link

The link now gives a 404!

@filipesilva
Copy link
Contributor

The link for 1.x can still be found at https://github.com/angular/angular-cli/wiki/1-x-stories-linked-library.

For 6.x we added the library creation functionality, and have a new story at https://github.com/angular/angular-cli/wiki/stories-create-library.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity3: broken
Projects
None yet
Development

No branches or pull requests

5 participants