Skip to content

"Please add a @NgModule annotation" error in 1.0.4. Works in 1.0.3. #6429

@mderoche

Description

@mderoche

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.4
node: 6.10.0
os: darwin x64
@angular/common: 4.1.3
@angular/compiler: 4.1.3
@angular/core: 4.1.3
@angular/forms: 4.1.3
@angular/http: 4.1.3
@angular/platform-browser: 4.1.3
@angular/platform-browser-dynamic: 4.1.3
@angular/router: 4.1.3
@angular/cli: 1.0.4
@angular/compiler-cli: 4.1.3

Repro steps.

  1. Clone this sample module, which allegedly uses the current recommended Angular package format: https://github.com/jasonaden/simple-ui-lib
  2. Create new test app with: ng new testApp
  3. Build simple-ui-lib with sh build.sh
  4. npm link simple-ui-lib's /dist
  5. Go to the testApp and npm link simple-ui-lib
  6. Import the module in testApp: import { BoxModule } from 'simple-ui-lib';
  7. Add BoxModule to the imports in testApp's app module

The log given by the failure.

compiler.es5.js:1540 Uncaught Error: Unexpected value 'BoxModule' imported by the module 'AppModule'. Please add a @NgModule annotation.
at syntaxError (http://localhost:4200/vendor.bundle.js:29714:34)
at http://localhost:4200/vendor.bundle.js:42668:44
at Array.forEach (native)
at CompileMetadataResolver.getNgModuleMetadata (http://localhost:4200/vendor.bundle.js:42651:49)
at JitCompiler._loadModules (http://localhost:4200/vendor.bundle.js:53804:66)
at JitCompiler.compileModuleAndComponents (http://localhost:4200/vendor.bundle.js:53763:52)
at JitCompiler.compileModuleAsync (http://localhost:4200/vendor.bundle.js:53725:23)
at PlatformRef
.bootstrapModuleWithZone (http://localhost:4200/vendor.bundle.js:5731:25)
at PlatformRef
.bootstrapModule (http://localhost:4200/vendor.bundle.js:5717:21)
at Object.116 (http://localhost:4200/main.bundle.js:117:124)

Desired functionality.

I'd assume that since this error spawns from both the recommended package setup, and a default new CLI application, that it should run with no errors right out of the box.

Mention any other details that might be useful.

This works in 1.0.3, but breaks in 1.0.4. (Broken in 1.1.0-rc.0 as well.) Not sure if this is actually a bug, or some change in how Angular CLI expects outside modules to be built.

Metadata

Metadata

Assignees

Labels

P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentseverity3: broken

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions