New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New help #8255
New help #8255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment.
.then(([availableOptions, nonSchematicOptions]: [SchematicAvailableOptions[], any[]]) => { | ||
const output: string[] = []; | ||
[...(nonSchematicOptions || []), ...availableOptions] | ||
.filter(opt => opt.name !== 'name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there's no way on the command line to specify anything other than string, boolean,s and numbers, you should filter anything else too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that means that things like --spec
would not be reflected with help, and I don't agree. I filtered out name
as it is an argument and not an option.
@@ -67,7 +67,9 @@ const HelpCommand = Command.extend({ | |||
if (commandOptions.short) { | |||
this.ui.writeLine(command.printShortHelp(commandOptions)); | |||
} else if (command.printDetailedHelp(commandOptions, rawArgs)) { | |||
this.ui.writeLine('cool'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
const result = command.printDetailedHelp(commandOptions, rawArgs); | ||
this.ui.writeLine('not cool', result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.