-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@angular/cli): display app index or name in process title when s… #8772
Conversation
2637080
to
2656f2c
Compare
Had tests like import { killAllProcesses } from '../../../utils/process';
import { ngServe } from '../../../utils/project';
export default function () {
return Promise.resolve()
.then(() => ngServe('--app', '0'))
.then(() => {
if (!process.title.match(/ng - app 0/)) {
throw new Error('Process title does not match expected value.');
}
})
.then(() => killAllProcesses(), (err) => { killAllProcesses(); throw err; });
} but removed them because they were failing on Travis CI and appVeyor. The process title was set to This and another test for checking app by name (not index) were working locally on Win10, cygwin, any idea how we can make them work on CI environments ? @filipesilva @Brocco Besides that, it works as described in original issue. Also, for consideration, the original |
@hansl can you take a look please? |
This seems to have gone stale, do we still need this change? |
Hi @alexeagle ! As you might noticed this is a rather very old PR from December 2017, it was meant to display app name (instead of app index) in the toolbar of the console when running specific app in a multi app scenario. Angular CLI experience quite some evolution since that time so I don't really know if this is still applicable. Might have a look and try to update it if you think it is worth it :) |
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Hi @tomastrajan! This PR has merge conflicts due to recent upstream merges. |
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.
Closes #8772 Fixes #6888 Special thanks to @tomastrajan for original PR.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…pecified
Closes #6888
This sets process title to
ng - app <index>
when used with--app 0
or to
ng - <app-name>
when used with--app appName