Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular/cli): display app index or name in process title when s… #8772

Closed

Conversation

tomastrajan
Copy link
Contributor

…pecified

Closes #6888

This sets process title to ng - app <index> when used with --app 0
or to ng - <app-name> when used with --app appName

@tomastrajan
Copy link
Contributor Author

Had tests like

import { killAllProcesses } from '../../../utils/process';
import { ngServe } from '../../../utils/project';

export default function () {
  return Promise.resolve()
    .then(() => ngServe('--app', '0'))
    .then(() => {
      if (!process.title.match(/ng - app 0/)) {
        throw new Error('Process title does not match expected value.');
      }
    })
    .then(() => killAllProcesses(), (err) => { killAllProcesses(); throw err; });
}

but removed them because they were failing on Travis CI and appVeyor. The process title was set to node in those environments.

This and another test for checking app by name (not index) were working locally on Win10, cygwin, any idea how we can make them work on CI environments ? @filipesilva @Brocco

Besides that, it works as described in original issue. Also, for consideration, the original ng process name is not tested either.

@filipesilva
Copy link
Contributor

@hansl can you take a look please?

@hansl hansl removed their assignment Feb 8, 2018
@alexeagle
Copy link
Contributor

This seems to have gone stale, do we still need this change?
Sorry @tomastrajan

@alexeagle alexeagle added the needs: discussion On the agenda for team meeting to determine next steps label Aug 14, 2018
@tomastrajan
Copy link
Contributor Author

Hi @alexeagle ! As you might noticed this is a rather very old PR from December 2017, it was meant to display app name (instead of app index) in the toolbar of the console when running specific app in a multi app scenario. Angular CLI experience quite some evolution since that time so I don't really know if this is still applicable. Might have a look and try to update it if you think it is worth it :)

@alexeagle alexeagle removed the needs: discussion On the agenda for team meeting to determine next steps label Aug 16, 2018
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 16, 2018
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 16, 2018
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 16, 2018
@ngbot
Copy link

ngbot bot commented Aug 17, 2018

Hi @tomastrajan! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

hansl added a commit to hansl/angular-cli that referenced this pull request Aug 17, 2018
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 17, 2018
hansl added a commit to hansl/angular-cli that referenced this pull request Aug 19, 2018
@hansl hansl closed this in #11920 Aug 19, 2018
hansl added a commit that referenced this pull request Aug 19, 2018
Closes #8772
Fixes #6888

Special thanks to @tomastrajan for original PR.
@tomastrajan tomastrajan deleted the app-name-in-process-title branch August 20, 2018 15:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display app name in process.title if running specific app
5 participants