1.1.x #9399

daequan60 · 2018-01-26T13:09:40Z

fu..k..im.i..u..c..

@raymondkarstensen

Thanks to @raymondkarstensen for this solution. Fix #975

…#6279) when implementing i18n following https://angular.io/docs/ts/latest/cookbook/i18n.html and https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358 when running in `development` to be consistent with `production` I am using ``` ng serve --deploy-url /en/ --base-href /en/ \ --aot --locale en --i18n-file ./src/locale/messages.en.xlf ``` running the app this way, on routes other than `http://localhost:4200/en/` the `webpack-dev-server` was always saying that the route is not found, so this commit fixes that

See #6033 for context.

#6276)

…uard with dry-run flag

Currently vendor Angular libraries will have their *.ngfactory.ts in main.ts when building with `--aot`. The easiest way to see this is with `source-map-explorer. This PR correctly puts them in vendor.ts.

This allows generating nested components or other blurprint outputs.

…vided

`prepree2e` doesn't run because it's a lifecycle script for a lifecycle script, but even if it did it would not work because there is nothing coordinating the serve and e2e processes. Users must manually initialize the server prior to running e2e tests after ejecting. Related to #6171

…zy loaded modules Currently, code splitting derived from routes with the loadChildren property only works if the resolved source file is a *.ts file in the source directory of your angular-cli project. If your project uses an npm package that has a route with loadChildren, the build will resolve the lazy loaded module as a *.d.ts definition file and then attempt to find an *.d.ts.ngfactory.ts file in the generated AOT directory, which does not exist. This fixes the path generation logic so the build will look for a *.ngfactory.ts file in $$_gendir/node_modules. Closes #5594

This reverts commit ba15605. The commit introduced non idiomatic Protractor code.

…rapper

…rning

The generated app component spec checks for the string "Welcome to {{title}}!!", which is only output by the generated `app.component.htm`l file, not the generated inline template in `app.component.ts` when the `--inline-template` option is passed to the `ng new` command. This causes a test failure when generating a new app with `--inline-template`.

Existing URL that is generated in the scaffold gives a 404. Updating this to the correct version.

…ndefined. (#6617)

This is only useful when using webpack directly. Does not affect the CLI. Performance is going to be impacted, but we do not type check after the loaders. TODO: add typechecking if the source we receive from Webpack is different from the host.

…ect dir A previous change broke the logic which brings an application ngsw-manifest.json into the Webpack build for merging with the auto-generated configuration. It caused the GlobCopyWebpackPlugin to look in the wrong directory for the existing manifest. This change sets the working directory for the copy plugin explicitly. Fixes #6654.

googlebot · 2018-01-26T13:10:17Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

filipesilva · 2018-01-26T13:15:08Z

Closing as I think this PR was opened by mistake.

angular-automatic-lock-bot · 2019-09-12T07:41:30Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva and others added 30 commits May 9, 2017 14:32

release: 1.1.0-beta.1

5a6d772

docs: add changelog for 1.1.0-beta.1

88e6e93

fix(@angular/cli): allow e2e multi capabilities

4f48be0

Thanks to @raymondkarstensen for this solution. Fix #975

fix(@angular/cli): adds language to index.html for accessibility

cfe60b5

docs(@angular/cli): fix sample home.md

0f388ea

docs(@angular/cli): fixes wrong link on corporate proxy story (#6299)

9ac6e9a

docs(@angular/cli): add github pages deploy docs (#6326)

d6d3842

docs(@angular/cli): document service worker support (#6324)

2be220c

docs: add global lib usage instructions (#6294)

62b50c2

See #6033 for context.

docs(@angular/cli): document resource copy (#6323)

38cb0e6

docs(@angular/cli): fixing new docs

afc25de

ci: fix branch comparison (#6247)

117d393

fix(@angular/cli): language-service as devDeps only (#6257)

02aaec4

fix(@angular/cli): enable full node module resolution for project deps (

54b1e35

#6276)

release: 1.1.0-rc.0

0a102ea

docs: add changelog for 1.1.0-rc.0

2f9e1f8

fix(@angular/cli): supress module file modification when generating g…

872737b

…uard with dry-run flag

fix(@angular/cli): put vendor ngfactory in vendor chunk

b4abe6d

Currently vendor Angular libraries will have their *.ngfactory.ts in main.ts when building with `--aot`. The easiest way to see this is with `source-map-explorer. This PR correctly puts them in vendor.ts.

refactor(@angular/cli): use memory FS for i18n extraction (#6306)

f143cb6

fix(@angular/cli): if user pass a full path, use the path (#6341)

6372f29

fix(@angular/cli): proper generation when the target dir exists (#5929)

e619df1

This allows generating nested components or other blurprint outputs.

feat(@ngtools/webpack): replace server bootstrap code (#5194)

ad026ef

fix(@angular/cli): update new project dev dependencies (#6415)

7bd4074

fix(@angular/cli): fix package name fetching from package.json

169dc9e

fix(@angular/cli): allow e2e tests to run if no-serve and port is pro…

3f10c5a

…vided

fix(@angular/cli): fix leading digit in file names from generate command

8683c3c

fix(@angular/cli): only values in enum should be allowed to update

7159920

cexbrayat and others added 22 commits June 7, 2017 21:00

fix(@angular/cli): restore e2e blueprint

390c624

This reverts commit ba15605. The commit introduced non idiomatic Protractor code.

refactor(@angular/cli): remove unnecessary use of ember-cli promise w…

01b082a

…rapper

fix(@angular/cli): fix env path

572351d

refactor(@angular/cli): simplify command registration

96d2a16

fix(@angular/cli): check package manager only when using one

aaf29dd

fix(@angular/cli): fix empty style urls

6a93451

fix(@angular/cli): allow public host option to accept only hostname

4f1c37b

fix(@angular/cli): fix delete path check

0a464ea

test: cleanup and convert acceptance tests to TypeScript

78dda8f

release: 1.1.1

c8d2723

refactor(@angular/cli): use UI method to show component generation wa…

a935ed5

…rning

fix(@angular/cli): provide file path with config parse errors

3927f93

fix(@angular/cli): URL for tour of heroes tutorial (#6672)

dbb7d6d

Existing URL that is generated in the scaffold gives a 404. Updating this to the correct version.

fix(@angular/cli): correct sourcemap source paths

cf66e6b

release: 1.1.2

1a797dc

fix(@angular/cli): package sort

1e1160f

refactor(@ngtools/webpack): refactor bootstrap refactoring

c9c27a6

fix(@ngtools/webpack): fix error in compiler CLI when i18nFormat is u…

8da9bcc

…ndefined. (#6617)

release: 1.1.3

c3a9835

daequan60 requested a review from hansl as a code owner January 26, 2018 13:09

googlebot added the cla: no label Jan 26, 2018

filipesilva closed this Jan 26, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

kyliau deleted the 1.1.x branch September 17, 2020 04:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.1.x #9399

1.1.x #9399

daequan60 commented Jan 26, 2018

googlebot commented Jan 26, 2018

filipesilva commented Jan 26, 2018

angular-automatic-lock-bot bot commented Sep 12, 2019

1.1.x #9399

1.1.x #9399

Conversation

daequan60 commented Jan 26, 2018

googlebot commented Jan 26, 2018

filipesilva commented Jan 26, 2018

angular-automatic-lock-bot bot commented Sep 12, 2019