Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running any schematic command with dry run a warning should show #10194

Closed
Brocco opened this issue Apr 5, 2018 · 1 comment · Fixed by #10261
Closed

When running any schematic command with dry run a warning should show #10194

Brocco opened this issue Apr 5, 2018 · 1 comment · Fixed by #10261
Assignees
@Brocco

Comments

@Brocco
Copy link
Contributor

Brocco commented Apr 5, 2018

Versions

6.0.0-rc.*

Repro steps

ng generate component foo --dry-run

Observed behavior

The output as if the command ran without dry run is shown

Desired behavior

A warning reminding the user that nothing has changed because of dry-run should be shown.
@Brocco Brocco added the 6.0.0-rc label Apr 5, 2018
@Brocco Brocco self-assigned this Apr 5, 2018
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 10, 2018
@Brocco
fix(@angular/cli): Show dry run warning
f4d9f0a 
fixes angular#10194
@Brocco Brocco mentioned this issue Apr 10, 2018
Merged
filipesilva pushed a commit that referenced this issue Apr 10, 2018
@Brocco @filipesilva
fix(@angular/cli): Show dry run warning
6870be2 
fixes #10194
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brocco Brocco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): Show dry run warning Brocco/angular-cli
1 participant
@Brocco