Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng update should check if I need to migrate my CLI config #10250

Closed
StephenFluin opened this issue Apr 9, 2018 · 1 comment · Fixed by #10380
Closed

ng update should check if I need to migrate my CLI config #10250

StephenFluin opened this issue Apr 9, 2018 · 1 comment · Fixed by #10380
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Milestone
v6.0.0

Comments

@StephenFluin
Copy link
Contributor

Versions

Angular CLI: 6.0.0-rc.2
Node: 9.2.0
OS: linux x64
Angular: 6.0.0-rc.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 6.0.0-rc.2
@angular-devkit/architect: 0.5.4
@ngtools/json-schema: 1.2.0
@schematics/update: 0.5.4
typescript: 2.9.0-dev.20180409
webpack: error

Repro steps

  1. new CLI 1.7 project
  2. Update to @angular/cli@next
  3. run ng update and do whatever it says until nothing is listed

Observed behavior

My CLI config has not been migrated, trying to run ng build throw:

An old project has been detected, which needs to be updated to Angular CLI 6.

Please run the following commands to update this project.

  ng update @angular/cli --migrate-only --from=1.7.1
  npm i

Desired behavior

Tell me I need to run this, or run it for me when I run ng update.
@hansl hansl added this to the v6.0.0 milestone Apr 12, 2018
@hansl hansl added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed 6.0.0-rc severity3: broken P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Apr 12, 2018
@hansl hansl self-assigned this Apr 12, 2018
hansl added a commit to hansl/angular-cli that referenced this issue Apr 18, 2018
@hansl
fix(@angular/cli): show the ng update message even on ng update
817eac4 
All commands that allow a missing workspace will show the message if the
angular workspace isnt up to date. It will not stop the process though.

Fix angular#10250
@hansl hansl mentioned this issue Apr 18, 2018
Merged
hansl added a commit to hansl/angular-cli that referenced this issue Apr 23, 2018
@hansl
fix(@angular/cli): show the ng update message even on ng update
692a82e 
All commands that allow a missing workspace will show the message if the
angular workspace isnt up to date. It will not stop the process though.

Fix angular#10250
hansl added a commit that referenced this issue Apr 24, 2018
@hansl
fix(@angular/cli): show the ng update message even on ng update
08623d5 
All commands that allow a missing workspace will show the message if the
angular workspace isnt up to date. It will not stop the process though.

Fix #10250
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): show the ng update message even on ng update hansl/angular-cli
3 participants
@StephenFluin @hansl @filipesilva