Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify 'nothing to be done' message #10253

Closed
StephenFluin opened this issue Apr 9, 2018 · 1 comment · Fixed by #10275
Closed

Clarify 'nothing to be done' message #10253

StephenFluin opened this issue Apr 9, 2018 · 1 comment · Fixed by #10275
Labels
severity1: confusing

Comments

@StephenFluin
Copy link
Contributor

Versions

Angular CLI: 6.0.0-rc.2
Node: 9.2.0
OS: linux x64
Angular: 6.0.0-rc.3
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 6.0.0-rc.2
@angular-devkit/architect: 0.5.4
@ngtools/json-schema: 1.2.0
@schematics/update: 0.5.4
typescript: 2.9.0-dev.20180409
webpack: error

Repro steps

Run ng update when there is a package listed that needs to be updated

Observed behavior

$ ng update
    We analyzed your package.json, there are some packages to update:
    
      Name                               Version                    Command to update
     ---------------------------------------------------------------------------------------------------------
      @types/node                        6.0.104 -> 9.6.2           npm install @types/node
      jasmine-core                       2.8.0 -> 3.1.0             npm install jasmine-core
      karma-jasmine-html-reporter        0.2.2 -> 1.0.0             npm install karma-jasmine-html-reporter
      protractor                         5.1.2 -> 5.3.1             npm install protractor
      ts-node                            4.1.0 -> 5.0.1             npm install ts-node
    
    
    There might be additional packages that are outdated.
    Or run ng update --all to try to update all at the same time.
    
Nothing to be done.

Desired behavior

The 'Nothing to be done.' message is confusing.

I recommend either removing it entirely, or changing it to something like 'By default no updates are run automatically, run one of the commands above to start updating'.
@hansl hansl self-assigned this Apr 10, 2018
hansl added a commit to hansl/angular-cli that referenced this issue Apr 10, 2018
@hansl
fix(@angular/cli): dont show Nothing to be done on update
4cea843 
Fix angular#10253.
@hansl hansl mentioned this issue Apr 10, 2018
Merged
hansl added a commit that referenced this issue Apr 11, 2018
@hansl
fix(@angular/cli): dont show Nothing to be done on update
858fa97 
Fix #10253.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
severity1: confusing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): dont show Nothing to be done on update hansl/angular-cli
3 participants
@StephenFluin @hansl @filipesilva