Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run migrate script as postinstall task in 6 if the user needs to update their project #10258

Closed
StephenFluin opened this issue Apr 9, 2018 · 4 comments · Fixed by #10291
Closed

Run migrate script as postinstall task in 6 if the user needs to update their project #10258

StephenFluin opened this issue Apr 9, 2018 · 4 comments · Fixed by #10291
Assignees
@hansl

Comments

@StephenFluin
Copy link
Contributor

StephenFluin commented Apr 9, 2018 •
edited

Desired behavior

user runs npm install @angular/cli (for v6)

Detect if they need to run ng update @angular/cli --migrate-only --from=1.7.3 and if they do, run it for them! :)
@hansl hansl self-assigned this Apr 10, 2018
@hansl
Copy link
Contributor

hansl commented Apr 10, 2018

Instead of actually running it, show a message to the user that they need to run it.

@StephenFluin
Copy link
Contributor Author

Why not run it for them if needed?

@hansl
Copy link
Contributor

hansl commented Apr 10, 2018

Because they might not want that (yet). It's an automated step that can be confusing if it errors out for example.

hansl added a commit to hansl/angular-cli that referenced this issue Apr 11, 2018
@hansl
fix(@angular/cli): on postinstall show a message if using an old vers…
3bf4ff0 
…ion of CLI

Fix angular#10258
hansl added a commit to hansl/angular-cli that referenced this issue Apr 11, 2018
@hansl
fix(@angular/cli): on postinstall show a message if using an old vers…
fd6def6 
…ion of CLI

Fix angular#10258
@hansl hansl mentioned this issue Apr 11, 2018
Merged
hansl added a commit to hansl/angular-cli that referenced this issue Apr 11, 2018
@hansl
fix(@angular/cli): on postinstall show a message if using an old vers…
4e6c653 
…ion of CLI

Fix angular#10258
@hansl hansl removed the 6.0.0-rc label Apr 12, 2018
filipesilva pushed a commit that referenced this issue Apr 12, 2018
@hansl @filipesilva
fix(@angular/cli): on postinstall show a message if using an old vers…
73075b7 
…ion of CLI

Fix #10258
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hansl hansl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): on postinstall show a message if using an old version of CLI hansl/angular-cli
3 participants
@StephenFluin @hansl @filipesilva