Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng new has skip-git, but can not use it. #10802

Closed
heyan12127 opened this issue May 11, 2018 · 5 comments · Fixed by #10851
Closed

ng new has skip-git, but can not use it. #10802

heyan12127 opened this issue May 11, 2018 · 5 comments · Fixed by #10851

Comments

@heyan12127
Copy link

Versions

ng -v
Angular CLI: 6.0.0
Node: 8.11.1
OS: linux x64
Angular: 
... 

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.6.0
@angular-devkit/core         0.6.0
@angular-devkit/schematics   0.6.0
@schematics/angular          0.6.0
@schematics/update           0.6.0
rxjs                         6.1.0
typescript                   2.7.2

Repro steps

  • Step 1 ng new my-app --skip-git=true or ng new --skip-git true

Observed behavior

Schematic input does not validate against the Schema: {"dryRun":false,"skipGit":"true","version":"6.0.0","directory":"","skipInstall":false,"linkCli":false,"commit":true,"newProjectRoot":"projects","inlineStyle":false,"inlineTemplate":false,"routing":false,"prefix":"app","style":"css","skipTests":false}
Errors:

  Data path ".skipGit" should be boolean.

Desired behavior
@heyan12127
Copy link
Author

heyan12127 commented May 11, 2018 •
edited

I am sorry to forget the Desired behavior.

Desired behavior
This parameter can be used normally.

@Brocco
Copy link
Contributor

Brocco commented May 11, 2018

I will look into this further, but for the immediate need, just run...

ng new my-app --skip-git

There is no need to include true as a value to --skip-git

@heyan12127
Copy link
Author

@Brocco It works, thanks! :)
And I can not find this configuration in wiki, is it an obsolete one?

@Brocco Brocco self-assigned this May 14, 2018
Brocco added a commit to Brocco/angular-cli that referenced this issue May 14, 2018
@Brocco
fix(@angular/cli): Fix parsing of new options
def382c 
fixes angular#10802
@Brocco Brocco mentioned this issue May 14, 2018
Merged
Brocco added a commit to Brocco/angular-cli that referenced this issue May 16, 2018
@Brocco
fix(@angular/cli): Fix parsing of new options
a3200ce 
fixes angular#10802
hansl pushed a commit that referenced this issue May 16, 2018
@Brocco @hansl
fix(@angular/cli): Fix parsing of new options
4631061 
fixes #10802
Brocco added a commit that referenced this issue May 17, 2018
@Brocco
fix(@angular/cli): Fix parsing of new options
0820650 
fixes #10802
@jacsamg
Copy link

jacsamg commented Aug 9, 2018

I can not find this documentation on the wiki either. Does it still exist?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): Fix parsing of new options Brocco/angular-cli
3 participants
@Brocco @heyan12127 @jacsamg