Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having multiple aliases for a schematics will always break #11389

Closed
hansl opened this issue Jun 27, 2018 · 1 comment · Fixed by #11390
Closed

Having multiple aliases for a schematics will always break #11389

hansl opened this issue Jun 27, 2018 · 1 comment · Fixed by #11390
Assignees
@hansl
Labels
area: devkit/schematics

Comments

@hansl
Copy link
Contributor

hansl commented Jun 27, 2018

The line here adds all the aliases, but from inside the loop, so the second alias check run will always find itself (since it was added in the last loop).

Either move that push() outside the inner loop or only push the current alias.
@hansl hansl self-assigned this Jun 27, 2018
hansl added a commit to hansl/angular-cli that referenced this issue Jun 27, 2018
@hansl
fix(@angular-devkit/schematics): fix declaring multiple aliases
4769a8e 
Fix angular#11389
@hansl hansl mentioned this issue Jun 27, 2018
Merged
clydin pushed a commit that referenced this issue Jul 2, 2018
@hansl @clydin
fix(@angular-devkit/schematics): fix declaring multiple aliases
5c1cafe 
Fix #11389
clydin pushed a commit that referenced this issue Jul 2, 2018
@hansl @clydin
fix(@angular-devkit/schematics): fix declaring multiple aliases
b5c92eb 
Fix #11389
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hansl hansl

Labels
area: devkit/schematics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/schematics): fix declaring multiple aliases hansl/angular-cli
2 participants
@hansl @clydin