Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning message is displayed when using TypeScript 2.9.2 #11665

Closed
micksatana opened this issue Jul 26, 2018 · 7 comments · Fixed by #11668
Closed

Warning message is displayed when using TypeScript 2.9.2 #11665

micksatana opened this issue Jul 26, 2018 · 7 comments · Fixed by #11668

Comments

@micksatana
Copy link

micksatana commented Jul 26, 2018 •
edited

Angular version 6.1.0 support typescript 2.9. But when I change typescript dependency in package.json. This warning is shown.

@angular/compiler-cli@6.1.0 requires typescript@'>=2.7.0 <2.8.0' but 2.9.2 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

    npm install typescript@'>=2.7.0 <2.8.0'

To disable this warning run "ng config cli.warnings.typescriptMismatch false".

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node --version
v8.9.4

npm --version
6.2.0

ng --version
Angular CLI: 6.1.0
Node: 8.9.4
OS: darwin x64
Angular: 6.1.0
... animations, bazel, cli, common, compiler, compiler-cli, core
... forms, http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.0
@angular-devkit/build-angular     0.7.0
@angular-devkit/build-optimizer   0.7.0
@angular-devkit/build-webpack     0.7.0
@angular-devkit/core              0.7.0
@angular-devkit/schematics        0.7.0
@ngtools/webpack                  6.1.0
@schematics/angular               0.7.0
@schematics/update                0.7.0
rxjs                              6.2.2
typescript                        2.9.2
webpack                           4.9.2

Repro steps

  1. Create new angular project
    ng new testNg61
  2. Change typescript version in package.json to 2.9.2
  3. Run npm i
  4. Run ng serve

The log given by the failure

@angular/compiler-cli@6.1.0 requires typescript@'>=2.7.0 <2.8.0' but 2.9.2 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

    npm install typescript@'>=2.7.0 <2.8.0'

To disable this warning run "ng config cli.warnings.typescriptMismatch false".

Desired functionality

Serve correctly without showing the warning

Mention any other details that might be useful

versionCombos variable in node_modules/@angular/cli/upgrade/version.js seem not being built correctly. The codes in upgrade/version.ts file seem correct.
@gkalpak gkalpak mentioned this issue Jul 26, 2018
Closed
@gkalpak
Copy link
Member

gkalpak commented Jul 26, 2018

Related: angular/angular#25141

sarunint added a commit to sarunint/angular-cli that referenced this issue Jul 26, 2018
@sarunint
fix(@angular/cli): use correct compiler version range
3ab59a8 
Close angular#11665, angular/angular#25141
@sarunint sarunint mentioned this issue Jul 26, 2018
Merged
@kylecordes
Copy link

As I recall from the last time there was such an upgrade, for various legacy reasons the compatibility version check is implemented in CLI, with the code of that understands the version relationship compiled into CLI (or dev kit). So they will need to be a CLI update to understand that a new range of Angular versions is compatible with the new range of TypeScript versions.

So we are just a bit patient, likely the next new CLI version should understand the new versions, and contain any other needed tweaks to make it all run smoothly.

hansl pushed a commit that referenced this issue Jul 26, 2018
@sarunint @hansl
fix(@angular/cli): use correct compiler version range
3fca66d 
Close #11665, angular/angular#25141
hansl pushed a commit that referenced this issue Jul 26, 2018
@sarunint @hansl
fix(@angular/cli): use correct compiler version range
1f19624 
Close #11665, angular/angular#25141
@ghost
Copy link

ghost commented Jul 26, 2018 •
edited by ghost

Is the referenced fix complete? Creating a new project in the CLI, why is the default typescript version set to "~2.7.2" in package.json? Shouldn't it be set to 2.9 by default now or is 2.7 the default for some specific reason?

Tried using latest 6.1.1 update -- same result.

@sarunint
Copy link
Contributor

@sundarchi1 Yes, it does fix the issue when you already upgraded to TypeScript 2.9. The issue you've just raised is a separated issue in which Angular CLI generates TypeScript 2.7 as default.

As for that issue, #11669 is pending.

@micksatana
Copy link
Author

@sundarchi1 I tested on my local. the fix is complete. when change version to 2.9.2, no warning display.

@hansl hansl mentioned this issue Aug 1, 2018
Closed
@sebek64
Copy link

sebek64 commented Aug 3, 2018

Although this is probably not a big problem, I see that @schematics/angular@0.7.2 still has a dependency on typescript < 2.8. It installs a separate copy of typescript, so it is compatible with global typescript in version 2.9.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): use correct compiler version range sarunint/angular-cli
5 participants
@kylecordes @micksatana @sebek64 @sarunint @gkalpak