Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On tsconfig.app.json exclude path is wrong #11829

Closed
code2nguyen opened this issue Aug 9, 2018 · 1 comment · Fixed by #11840
Closed

On tsconfig.app.json exclude path is wrong #11829

code2nguyen opened this issue Aug 9, 2018 · 1 comment · Fixed by #11840
Labels
area: schematics/angular
Milestone
needsTriage

Comments

@code2nguyen
Copy link

Bug Report or Feature Request (mark with an x)

- [ x ] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ x ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.1.2
Node: 8.11.1
OS: win32 x64
Angular: 6.1.0
... common, compiler, compiler-cli, core, forms, http
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.7.2
@angular-devkit/build-angular     0.7.2
@angular-devkit/build-optimizer   0.7.2
@angular-devkit/build-webpack     0.7.2
@angular-devkit/core              0.7.2
@angular-devkit/schematics        0.7.2
@angular/animations               6.1.1
@angular/cdk                      6.4.2
@angular/cli                      6.1.2
@angular/flex-layout              6.0.0-beta.17
@angular/material                 6.4.2
@angular/upgrade                  6.1.1
@ngtools/webpack                  6.1.2
@schematics/angular               0.7.2
@schematics/update                0.7.2
rxjs                              6.2.2
typescript                        2.7.2
webpack                           4.9.2

Repro steps

run ng new myproject

The log given by the failure

On myproject/src/tsconfig.app.json, exclude property is not correct

 "exclude": [
    "src/test.ts",
    "**/*.spec.ts"
  ]

Desired functionality

It should be

 "exclude": [
    "test.ts",
    "**/*.spec.ts"
  ]

Mention any other details that might be useful
@alan-agius4 alan-agius4 mentioned this issue Aug 10, 2018
Merged
@ngbot ngbot bot added this to the needsTriage milestone Aug 10, 2018
alexeagle pushed a commit that referenced this issue Aug 14, 2018
@alan-agius4 @alexeagle
fix(@schematics/angular): incorrect exclude path for test.ts
b99b6ba 
Closes #11829
alexeagle pushed a commit that referenced this issue Aug 14, 2018
@alan-agius4 @alexeagle
fix(@schematics/angular): incorrect exclude path for test.ts
b07e6ef 
Closes #11829
This was referenced Sep 22, 2018
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: schematics/angular
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(@schematics/angular): incorrect exclude path for test.ts
2 participants
@alexeagle @code2nguyen