Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly created blank schematic fails to build because of unused variable #11916

Closed
sis0k0 opened this issue Aug 16, 2018 · 1 comment · Fixed by #11917
Closed

Newly created blank schematic fails to build because of unused variable #11916

sis0k0 opened this issue Aug 16, 2018 · 1 comment · Fixed by #11917

Comments

@sis0k0
Copy link
Contributor

sis0k0 commented Aug 16, 2018

Bug Report or Feature Request (mark with an x)

- [X] bug report
- [ ] feature request

Scope

@schematics/schematics

Versions

@angular-devkit/schematics-cli v0.7.3

Repro steps

  1. Install the schematics CLI globally.
npm install -g @angular-devkit/schematics-cli
  1. Generate new schematics project with the blank schematic from @schematics/schematics.
schematics blank --name=test
  1. Navigate to the newly created project.
cd test
  1. Try to build the project.
npm run build

The log given by the failure

The build fails with the following TypeScript error:

src/test/index.ts:6:25 - error TS6133: 'options' is declared but its value is never read.

6 export function test(options: any): Rule {

Desired functionality

The newly created project should build successfully.
sis0k0 added a commit to sis0k0/angular-cli that referenced this issue Aug 16, 2018
@sis0k0
fix(@schematics/schematics): prefix unused argument with underscore
ed731b5 
The `options` arguments is not used in the function. This causes the
TypeScript compilation to fail.

fixes angular#11916
@sis0k0 sis0k0 mentioned this issue Aug 16, 2018
Merged
hansl pushed a commit that referenced this issue Aug 17, 2018
@sis0k0 @hansl
fix(@schematics/schematics): prefix unused argument with underscore
068dfa4 
The `options` arguments is not used in the function. This causes the
TypeScript compilation to fail.

fixes #11916
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@schematics/schematics): prefix unused argument with underscore sis0k0/angular-cli
1 participant
@sis0k0