Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular-devkit/core v0.7.5 published with broken typescript declarations #11992

Closed
vladimiry opened this issue Aug 23, 2018 · 5 comments · Fixed by #12001
Closed

@angular-devkit/core v0.7.5 published with broken typescript declarations #11992

vladimiry opened this issue Aug 23, 2018 · 5 comments · Fixed by #12001

Comments

@vladimiry
Copy link

vladimiry commented Aug 23, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions

node v8.9.4
yarn v1.9.4
typescript v3.0.1

Repro steps

Just run the build that uses @angular-devkit/core in any way.

The log given by the failure

Error output:

ERROR in node_modules/@angular-devkit/core/src/virtual-fs/host/test.d.ts(36,41): error TS2307: Cannot find module '../../../../../../../../../../../Users/hansl/Sources/hansl/angular-cli/packages/angular_devkit/core/src/virtual-fs/path'.
node_modules/@angular-devkit/core/src/virtual-fs/host/test.d.ts(44,33): error TS2307: Cannot find module '../../../../../../../../../../../Users/hansl/Sources/hansl/angular-cli/packages/angular_devkit/core/src/virtual-fs/path'.

Desired functionality

Declarations were not broken with previous v0.7.4 version.

Mention any other details that might be useful

Here is the workaround, tsconfig.json:

{
  "compilerOptions": {
    "skipLibCheck": true
  },
}
@vladimiry
Copy link
Author

cc @hansl

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Aug 24, 2018

Note: From the look of it it's due the import types which was introduced in TypeScript 2.9. A quick fix would be to import the type rather than inferring it.

Some more context about this issue;
#11893 (comment)

Ill will also double check, if this issue is fixed in the next versions of TypeScript, As it looks to me like it might be generated by the use of yarn workspaces or bazel build.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Aug 24, 2018

I tried to build angular core locally with Bazel and it looks like the types are being generated correctly even with the current version of TypeScript.

example;

protected _list(path: Path): import("@angular-devkit/core/src/virtual-fs/path").PathFragment[];

@aaaa0441
Copy link

aaaa0441 commented Sep 5, 2018

Hi @hansl, will there be a 0.7.6 release with this fixed? If yes, approximately when will that be?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants