Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of Module attributes inconsistent between default and generated #12509

Closed
marlowp opened this issue Oct 8, 2018 · 3 comments · Fixed by #12749
Closed

Order of Module attributes inconsistent between default and generated #12509

marlowp opened this issue Oct 8, 2018 · 3 comments · Fixed by #12749
Labels
area: schematics/angular freq1: low Only reported by a handful of users who observe it rarely good first issue severity2: inconvenient
Milestone
needsTriage

Comments

@marlowp
Copy link

marlowp commented Oct 8, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report
- [ ] feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.2.4
Node: 10.6.0
OS: win32 x64
Angular: 6.1.9
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.8.4
@angular-devkit/build-angular     0.8.4
@angular-devkit/build-optimizer   0.8.4
@angular-devkit/build-webpack     0.8.4
@angular-devkit/core              0.8.4
@angular-devkit/schematics        0.8.4
@angular/cdk                      6.4.5
@angular/cli                      6.2.4
@angular/material                 6.4.5
@ngtools/webpack                  6.2.4
@schematics/angular               0.8.4
@schematics/update                0.8.4
rxjs                              6.2.2
typescript                        2.9.2
webpack                           4.20.2

Repro steps

The default module created using ng new creates a module whose first attribute is declarations followed by imports, when you generate a new module using ng generate module the order of attributes is imports followed by declarations.

Desired functionality

The order should be consistent.

Mention any other details that might be useful

Looks like either of the following files needs updating:
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient area: schematics/angular good first issue labels Oct 8, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 8, 2018
@ZionDials
Copy link

I created a pull request for this and made them match for file generation. Thanks [https://github.com//pull/12528]

@alan-agius4 alan-agius4 mentioned this issue Oct 10, 2018
Closed
@inthevortex
Copy link

Has this issue been resolved?

@alan-agius4 alan-agius4 mentioned this issue Oct 25, 2018
Merged
kyliau pushed a commit that referenced this issue Nov 1, 2018
@alan-agius4
fix(@schematics/angular): order of module properties is inconsistent
a117698 
Closes #12509
kyliau pushed a commit to kyliau/angular-cli that referenced this issue Nov 1, 2018
@alan-agius4 @kyliau
fix(@schematics/angular): order of module properties is inconsistent
5ddbeae 
Closes angular#12509
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: schematics/angular freq1: low Only reported by a handful of users who observe it rarely good first issue severity2: inconvenient
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(@schematics/angular) order of module properties is inconsistent
4 participants
@inthevortex @marlowp @alan-agius4 @ZionDials