Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tslint.yaml in --lint-fix flag #12545

Closed
robertjk opened this issue Oct 10, 2018 · 1 comment · Fixed by #13356
Closed

Add support for tslint.yaml in --lint-fix flag #12545

robertjk opened this issue Oct 10, 2018 · 1 comment · Fixed by #13356
Labels
area: devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@robertjk
Copy link

robertjk commented Oct 10, 2018

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

node version: 10.10.10
npm version: 6.4.1
ng version: 6.2.1
OS: Arch Linux

Desired functionality

I'd like --lint-fix flag for ng generate to support tslint.yaml configuration in addition to tslint.json.

Mention any other details that might be useful

My TSLint configuration is in tslint.yaml file and ng lint works fine. Still ng generate --fix-lint gives error complaining tslint.json file is not present:

$ ng generate component shared/dropdown --lint-fix
Asked to run lint fixes, but could not find a tslint.json.

This is not consistent with ng lint nor with official tslint tool, as TSLint can be configured both in JSON and in YAML. Quoting official documentation:

When using the CLI or many third-party tools, a file named tslint.json or tslint.yaml is used to configure which rules get run and each of their options.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants