Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

production build fails with --sourceMap option if sweetalert2 is used. #12773

Closed
SanderElias opened this issue Oct 26, 2018 · 3 comments · Fixed by #12822
Closed

production build fails with --sourceMap option if sweetalert2 is used. #12773

SanderElias opened this issue Oct 26, 2018 · 3 comments · Fixed by #12822
Labels
area: devkit/build-optimizer freq2: medium severity5: regression type: bug/fix
Milestone
Backlog

Comments

@SanderElias
Copy link

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.2.1
Node: 10.10.0
OS: linux x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.8.6
@angular-devkit/build-angular     0.8.6
@angular-devkit/build-optimizer   0.8.6
@angular-devkit/build-webpack     0.8.6
@angular-devkit/core              0.8.1
@angular-devkit/schematics        0.8.1
@angular/cli                      6.2.1
@ngtools/webpack                  6.2.6
@schematics/angular               0.8.1
@schematics/update                0.8.1
rxjs                              6.3.3
typescript                        2.9.2
webpack                           4.23.1

Repro steps

clone this repo
yarn ng build --prod --sourceMap

The build will end with:
image

Mention any other details that might be useful

Filed this issue at the request of @filipesilva
@filipesilva
Copy link
Contributor

I suspect this is related to a TS bug while parsing comments with allowJs turned on, as we do inside build-optimizer. Probably in that file shown in the error. Next steps are for us to try and make a repro just using TS and see if that's the case.

@ngbot ngbot bot added this to the Backlog milestone Oct 26, 2018
@SanderElias SanderElias mentioned this issue Oct 27, 2018
Closed
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Oct 31, 2018
@filipesilva
fix(@angular-devkit/build-optimizer): update typescript to 3.1.4
b87c628 
Fix angular#12773
@filipesilva filipesilva mentioned this issue Oct 31, 2018
Merged
@filipesilva
Copy link
Contributor

I tried to make a reproduction to report this to TypeScript, and found the problem was still there in 3.1.3 but not anymore in 3.1.4. #12822 should fix this on our side.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Nov 1, 2018
@filipesilva
fix(@angular-devkit/build-optimizer): update typescript to 3.1.5
cf3d89b 
Fix angular#12773
alexeagle pushed a commit that referenced this issue Nov 1, 2018
@filipesilva @alexeagle
fix(@angular-devkit/build-optimizer): update typescript to 3.1.5
db784ec 
Fix #12773
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: devkit/build-optimizer freq2: medium severity5: regression type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Update to TypeScript 3.1.5 filipesilva/angular-cli
2 participants
@SanderElias @filipesilva