ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914

christianmorante · 2018-11-09T20:21:48Z

Bug Report or Feature Request (mark with an `x`)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an `x`)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [x] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 6.2.5
Node: 8.11.3
OS: win32 x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.8.5
@angular-devkit/build-angular 0.8.5
@angular-devkit/build-optimizer 0.8.5
@angular-devkit/build-webpack 0.8.5
@angular-devkit/core 0.8.5
@angular-devkit/schematics 0.8.5
@angular/cdk 6.4.7
@angular/cli 6.2.5
@angular/material 6.4.7
@angular/pwa 0.10.5
@ngtools/webpack 6.2.5
@schematics/angular 0.8.5
@schematics/update 0.8.5
rxjs 6.2.2
typescript 2.9.2
webpack 4.20.2

Repro steps

ng new pwademo
ng add @angular/material
ng build --prod
ng add @angular/pwa

The log given by the failure

Installing packages for tooling via npm.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

@angular/pwa@0.10.5
updated 1 package in 47.645s
Installed packages for tooling via npm.
Maximum call stack size exceeded

Desired functionality

The command doesnt add automatically PWA features to my Angular application such as manifest file or icons in assets folder or edit my index.html file with reference to manifest, only show me the error message
Maximum call stack size exceeded

Mention any other details that might be useful

The text was updated successfully, but these errors were encountered:

clydin · 2018-11-09T20:31:26Z

Currently you will need to execute ng add @angular/pwa@v6-lts to ensure the version compatible with Angular 6 is used.

christianmorante · 2018-11-09T20:35:53Z

I'm just running the command
ng add @angular/pwa
but its take a long time to show me error message: Maximum call stack size exceeded

jakawell · 2018-11-09T21:37:47Z

I'm having the same issue. I was able to get it to work by specifying the previous stable release:
ng add @angular/pwa@0.8.7 --project my-project-name

christianmorante · 2018-11-09T21:46:10Z

Oh hell, it worked for me. But is there any clue as to why?
Thanks @jakawell.

jakawell · 2018-11-09T22:05:21Z

I'm not sure. The latest version was just published recently, so I'm guessing something isn't quite right with it.

alan-agius4 · 2018-11-10T14:36:58Z

The latest version is targeted to be used with Version 7.

azaddjan · 2018-11-11T01:51:33Z

No issue with bellow version. Update your cli.

ng version

Angular CLI: 7.0.5
Node: 10.11.0
Angular: 7.0.3

tsukhu · 2018-11-14T06:32:41Z

@0.8.7

I am using nx extensions cli v7 and angular cli 7.0.5 and ran into the same issue.
@jakawell thanks for your solution , that one works (using the older version/stable version of @angular/pwa@0.8.7)

alan-agius4 · 2018-11-14T08:05:08Z

Hi, the problem is no longer reproducable if you use the latest versions of the CLI and devkit packages.

    "@angular-devkit/build-angular": "^0.10.5",
    "@angular/cli": "^7.0.5",

igwemagnusnnamdi65 · 2018-11-15T07:46:36Z

@jakawell thanks so much.You rock.

imen-developer · 2018-11-19T13:08:50Z

it should be fixed by updating your global angular cli to the last stable version

jcuervas · 2018-11-26T15:36:02Z

"@angular-devkit/build-angular": "^0.10.5",
"@angular/cli": "^7.0.5",
This worked for me also (in project package.json)

@clydin

As suggested by @clydin in angular/angular-cli#12914

IgorMinar · 2018-11-28T17:57:36Z

The root cause here is that the @angular/pwa doesn't declare any peerDependency in the package.json config, so the npm client installs the latest one which doesn't seem to be compatible. To fix this we need to define a peerDep on the right version.

To fix this for v6 developers, we might need to cut a version that is compatible with v6 and declares a peerDep on v6.

gkalpak · 2018-11-28T19:55:13Z

peerDependency on what? Angular or cli/devkit?

IgorMinar · 2018-11-29T02:20:23Z

on the cli because it's the cli that provides schematics and other stuff needed by @angular/pwa

gkalpak · 2018-11-29T07:48:35Z

Makes sense.
I just want to point out that some parts (such as the ngsw-config.json) must be compatible with the @angular/service-worker version used. Maybe we should move them to @angular/service-worker and have cli somehow get them from there.

IgorMinar · 2018-11-30T16:20:37Z

since cli and the framework are aligned on major versions, it should be fine to pin pwa to just cli. no?

…

On Wed, Nov 28, 2018 at 11:48 PM George Kalpakas ***@***.***> wrote: Makes sense. I just want to point out that some parts (such as the ngsw-config.json) must be compatible with the @angular/service-worker version used. Maybe we should move them to @angular/service-worker and have cli somehow get them from there. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#12914 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6EB0KHPxEyQZ9wauacG9722gYHE9ks5uz5FVgaJpZM4YXdGF> .

gkalpak · 2018-11-30T17:35:50Z

If we only change things related to the ngsw-config in major versions, yes.

…2914 (comment))

marcobaccaro · 2018-12-11T22:17:09Z

If you delete the node_modules folder it works fine.

saurabhzh · 2018-12-15T11:49:55Z

For my case I updated my angular CLI and then 'ng add @angular/pwa' is working fine.
To update Angular CLI in your project use:

npm uninstall --save-dev angular-cli
npm install --save-dev @angular/cli@latest

…encies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer dependencies that match the package versions supplied in the project's package.json Fixes angular#12914

…encies If no version specifier is supplied `ng add` will now try to find the most recent version of the package that has peer dependencies that match the package versions supplied in the project's package.json Fixes #12914

alan-agius4 · 2019-01-21T09:43:09Z

Fixed via #13286

nreynis · 2019-01-29T09:38:15Z

~~@alan-agius4 It's not fixed, can you please reopen the issue ?~~

Just updated to @angular/cli:7.2.3 and the error is still here.
I've also deleted the node_modules directory and it still fails the same way.

Nevermind, I updated my global cli but didn't noticed the project was using an older one installed locally. Bumped both it's working fine now. Sorry for the trouble.

cnscorpions · 2019-03-23T16:48:45Z

I'm having the same issue. I was able to get it to work by specifying the previous stable release:
ng add @angular/pwa@0.8.7 --project my-project-name

it seems to work, thnk u

MayumyCH · 2019-08-07T15:31:48Z

@jakawell muchas gracias. Me funciono (y)

angular-automatic-lock-bot · 2019-09-09T19:42:26Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 mentioned this issue Nov 11, 2018

ng add @angula/pwa Maximum call stack size exceeded error #12928

Closed

alan-agius4 changed the title ~~ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5~~ ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) Nov 11, 2018

alan-agius4 added the area: angular/cli label Nov 11, 2018

ngbot bot added this to the needsTriage milestone Nov 11, 2018

alan-agius4 added area: angular/pwa and removed area: angular/cli labels Nov 11, 2018

alan-agius4 closed this as completed Nov 14, 2018

alan-agius4 mentioned this issue Nov 15, 2018

ng add @angular/pwa doesn't create service worker script #12098

Closed

adamkasztenny added a commit to adamkasztenny/angular that referenced this issue Nov 28, 2018

docs: Add LTS version to PWA install

df93667

As suggested by @clydin in angular/angular-cli#12914

adamkasztenny mentioned this issue Nov 28, 2018

docs: Add LTS version to PWA install angular/angular#27328

Closed

13 tasks

IgorMinar reopened this Nov 28, 2018

hansl added the needs: discussion On the agenda for team meeting to determine next steps label Nov 29, 2018

jagomf added a commit to TrainingITCourses/final-jagomf that referenced this issue Dec 10, 2018

Instalado Angular PWA usando la versión v6-lts (angular/angular-cli#1…

164aff7

…2914 (comment))

hansl removed the needs: discussion On the agenda for team meeting to determine next steps label Dec 20, 2018

alan-agius4 mentioned this issue Dec 22, 2018

[6.2.x] fix(@angular/cli): 'ng add' selects supported version via peer dependencies #13286

Merged

alan-agius4 closed this as completed Jan 21, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914

ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914

christianmorante commented Nov 9, 2018 •

edited

clydin commented Nov 9, 2018 •

edited

christianmorante commented Nov 9, 2018 •

edited

jakawell commented Nov 9, 2018 •

edited

christianmorante commented Nov 9, 2018

jakawell commented Nov 9, 2018

alan-agius4 commented Nov 10, 2018

azaddjan commented Nov 11, 2018

tsukhu commented Nov 14, 2018 •

edited

alan-agius4 commented Nov 14, 2018

igwemagnusnnamdi65 commented Nov 15, 2018

imen-developer commented Nov 19, 2018

jcuervas commented Nov 26, 2018

IgorMinar commented Nov 28, 2018

gkalpak commented Nov 28, 2018

IgorMinar commented Nov 29, 2018

gkalpak commented Nov 29, 2018

IgorMinar commented Nov 30, 2018 via email

gkalpak commented Nov 30, 2018

marcobaccaro commented Dec 11, 2018

saurabhzh commented Dec 15, 2018

alan-agius4 commented Jan 21, 2019

nreynis commented Jan 29, 2019 •

edited

cnscorpions commented Mar 23, 2019

MayumyCH commented Aug 7, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914

ng add @angular/pwa doesn't work correctly in angular-cli 6.2.5 (Maximum call stack size exceeded) #12914

Comments

christianmorante commented Nov 9, 2018 • edited

Bug Report or Feature Request (mark with an x)

Command (mark with an x)

Versions

Package Version

Repro steps

The log given by the failure

Desired functionality

Mention any other details that might be useful

clydin commented Nov 9, 2018 • edited

christianmorante commented Nov 9, 2018 • edited

jakawell commented Nov 9, 2018 • edited

christianmorante commented Nov 9, 2018

jakawell commented Nov 9, 2018

alan-agius4 commented Nov 10, 2018

azaddjan commented Nov 11, 2018

tsukhu commented Nov 14, 2018 • edited

alan-agius4 commented Nov 14, 2018

igwemagnusnnamdi65 commented Nov 15, 2018

imen-developer commented Nov 19, 2018

jcuervas commented Nov 26, 2018

IgorMinar commented Nov 28, 2018

gkalpak commented Nov 28, 2018

IgorMinar commented Nov 29, 2018

gkalpak commented Nov 29, 2018

IgorMinar commented Nov 30, 2018 via email

gkalpak commented Nov 30, 2018

marcobaccaro commented Dec 11, 2018

saurabhzh commented Dec 15, 2018

alan-agius4 commented Jan 21, 2019

nreynis commented Jan 29, 2019 • edited

cnscorpions commented Mar 23, 2019

MayumyCH commented Aug 7, 2019

angular-automatic-lock-bot bot commented Sep 9, 2019

christianmorante commented Nov 9, 2018 •

edited

Bug Report or Feature Request (mark with an `x`)

Command (mark with an `x`)

clydin commented Nov 9, 2018 •

edited

christianmorante commented Nov 9, 2018 •

edited

jakawell commented Nov 9, 2018 •

edited

tsukhu commented Nov 14, 2018 •

edited

nreynis commented Jan 29, 2019 •

edited