Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng version should report if you are opted into the Ivy preview #14491

Closed
StephenFluin opened this issue May 21, 2019 · 5 comments 路 Fixed by #16296
Closed

ng version should report if you are opted into the Ivy preview #14491

StephenFluin opened this issue May 21, 2019 · 5 comments 路 Fixed by #16296
Labels
area: devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@StephenFluin
Copy link
Contributor

馃殌 Feature request

Command (mark with an x)

- [x] version

Description

It will be important to know if developers are using Ivy or not when debugging and reproducing issues.

Describe the solution you'd like

ng version should show if the user has opted into the Ivy preview or not.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented May 22, 2019

Not sure how this fits in ng version since Ivy opt-in is not related to the package version and is project specific not a global flag.

Ie, in a workspace one application can be compiled using Ivy and another might be using VE.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented May 22, 2019

Also, it might be the case that ng test run using the VE compiler while ng build and ng serve using the Ivy compiler. The actual opt-in guide only states how to opt-in for build and serve, however users can still opt-in to use Ivy in tests

Maybe what we can do is to print a message during each compilation stating the compiler being used and maybe ask for the compiler type when filling a new issue? Though that would add an addition question to the issue template.

@StephenFluin
Copy link
Contributor Author

Makes sense. Perhaps instead we could inform users whenever we do an Ivy compilation instead of a ViewEngine compilation with a log message?

I'd be happy to close this if I'm off base, but I want to make sure developers know what's going on, if for example, another developer on their team opts them into the preview.

@alan-agius4
Copy link
Collaborator

Yeah I think printing a message makes total sense.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants