Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different versions of RxJS not supported #14579

Closed
ahasall opened this issue May 30, 2019 · 2 comments · Fixed by #14586
Closed

Different versions of RxJS not supported #14579

ahasall opened this issue May 30, 2019 · 2 comments · Fixed by #14586
Labels
area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
Backlog

Comments

@ahasall
Copy link
Contributor

ahasall commented May 30, 2019

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

No

Description

The Angular CLI ecosystem supports only one version of RxJS which is 6.4.0.
I expect different versions of RxJS to be supported because Angular itself supports a broader range of RxJS versions (^6.4.0)

🔬 Minimal Reproduction

https://github.com/ahasall/rxjs-v6.4-v6.5-bug

yarn install
yarn build

🔥 Exception or Error

If you use RxJS v6.5.2 and a library that depends on RxJS v6.4.0, you may get a TS2322 error.

For example, when working with the new Architect API, I encounter the following error:
Type 'Observable' is not assignable to type 'BuilderOutputLike' while

export declare type BuilderOutputLike = Observable<BuilderOutput> | Promise<BuilderOutput> | BuilderOutput;

🌍 Your Environment


@angular-devkit/architect          0.800.0
@angular-devkit/build-angular      0.800.0
@angular-devkit/build-ng-packagr   0.800.0
@angular-devkit/build-optimizer    0.800.0
@angular-devkit/build-webpack      0.800.0
@angular-devkit/core               8.0.0
@angular-devkit/schematics         8.0.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.0.0
@schematics/angular                8.0.0
@schematics/update                 0.800.0
ng-packagr                         5.2.0
rxjs                               6.5.2
typescript                         3.5.1
webpack                            4.30.0

Anything else relevant?
A workaround for people encountering this issue is to downgrade their version of RxJS to 6.4.0
@alan-agius4
Copy link
Collaborator

Related to ReactiveX/rxjs#4818

@alan-agius4 alan-agius4 added area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken labels May 30, 2019
@ngbot ngbot bot added this to the needsTriage milestone May 30, 2019
@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 30, 2019
clydin added a commit to clydin/angular-cli that referenced this issue May 30, 2019
@clydin
fix(@angular-devkit/architect): support all observable types as build…
9572804 
… results

Fixes angular#14579
@clydin clydin mentioned this issue May 30, 2019
Merged
clydin added a commit to clydin/angular-cli that referenced this issue May 30, 2019
@clydin
fix(@angular-devkit/architect): support all observable types as build…
6c1ffec 
… results

Fixes angular#14579
alexeagle pushed a commit that referenced this issue May 30, 2019
@clydin @alexeagle
fix(@angular-devkit/architect): support all observable types as build…
19ed795 
… results

Fixes #14579
alexeagle pushed a commit that referenced this issue May 30, 2019
@clydin @alexeagle
fix(@angular-devkit/architect): support all observable types as build…
cf3e3af 
… results

Fixes #14579
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/architect): support all observable types as build results clydin/angular-cli
3 participants
@ahasall @alan-agius4 @clydin