Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning when users use a deprecated option in config #14966

Closed
alan-agius4 opened this issue Jul 2, 2019 · 1 comment 路 Fixed by #18520
Closed

Display warning when users use a deprecated option in config #14966

alan-agius4 opened this issue Jul 2, 2019 · 1 comment 路 Fixed by #18520
Assignees
@alan-agius4
Labels
area: angular/cli feature Issue that requests a new feature freq3: high
Milestone
Backlog

Comments

@alan-agius4
Copy link
Collaborator

馃殌 Feature request

Description

At the moment when a deprecated option is passed via the command line we display a warning

ng build --es5BrowserSupport
Option "es5BrowserSupport" is deprecated: This will be determined from the list of supported browsers specified in the 'browserslist' file.

However, if this option is set in the via the config we don't display anything.

We should warn the users when a deprecated option is used, both when they configure it in the config or when they use it via the command line.
@alan-agius4 alan-agius4 added feature Issue that requests a new feature area: angular/cli labels Jul 2, 2019
@ngbot ngbot bot modified the milestone: Backlog Jul 2, 2019
@alan-agius4 alan-agius4 modified the milestones: Backlog, 9.0.x Jul 21, 2019
@dgp1130 dgp1130 modified the milestones: v9-candidates, Backlog Nov 21, 2019
@alan-agius4 alan-agius4 self-assigned this Aug 13, 2020
@alan-agius4 alan-agius4 mentioned this issue Aug 13, 2020
Merged
alan-agius4 added a commit that referenced this issue Aug 17, 2020
@alan-agius4
feat(@angular/cli): show warning when using deprecated options
951d99e 
With this change we show a warning when a deprecated option is also defined in the workspace configuration file (angular.json).

Closes: #14966
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: angular/cli feature Issue that requests a new feature freq3: high
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Show warning on deprecated option usage
2 participants
@dgp1130 @alan-agius4