ng update wrote wrong path of main.ts and polyfill.ts in tsconfig.app.json #16800

SachinShekhar · 2020-01-30T13:22:41Z

🐞 bug report

Affected Package

N/A

Is this a regression?

Yes, the previous version in which this bug was not present was: v8

Description

After upgrading to v9, I found that path of main.ts and polyfill.ts are wrongly written in tsconfig.app.json which makes the app unusable.

🔬 Minimal Reproduction

Checkout this commit SachinShekhar/angular-ssr-prerendering-bug@593f599 and run ng update @angular/core @angular/cli --next

The result will be SachinShekhar/angular-ssr-prerendering-bug@5528e5f#diff-d090b1ccd7cff3dfff369e150143bb09

🔥 Exception or Error




ERROR in error TS6053: File 'x:/Bugs/angular-ssr-prerendering-bug/apps/angular-ssr-prerendering-bug/apps/angular-ssr-prerendering-bug/src/main.ts' not found.
error TS6053: File 'x:/Bugs/angular-ssr-prerendering-bug/apps/angular-ssr-prerendering-bug/apps/angular-ssr-prerendering-bug/src/polyfills.ts' not found.

This error is thrown when I run ng serve.

🌍 Your Environment

Angular Version:




Angular CLI: 9.0.0-rc.11
Node: 12.6.0
OS: win32 x64

Angular: 9.0.0-rc.11
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-rc.11
@angular-devkit/build-angular     0.900.0-rc.11
@angular-devkit/build-optimizer   0.900.0-rc.11
@angular-devkit/build-webpack     0.900.0-rc.11
@angular-devkit/core              9.0.0-rc.11
@angular-devkit/schematics        9.0.0-rc.11
@ngtools/webpack                  9.0.0-rc.11
@nguniversal/builders             9.0.0-rc.1
@nguniversal/common               9.0.0-rc.1
@nguniversal/express-engine       9.0.0-rc.1
@schematics/angular               9.0.0-rc.11
@schematics/update                0.900.0-rc.11
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Anything else relevant?

This project uses NX schematics. I've a feeling that it is the culprit.

The text was updated successfully, but these errors were encountered:

filipesilva · 2020-01-30T16:35:19Z

Heya, thanks for the detailed repro! This happens because of the windows-style path separators in your angular.json:

 "projects": {
    "angular-ssr-prerendering-bug": {
      "projectType": "application",
      "schematics": {},
      "root": "apps\\angular-ssr-prerendering-bug",
      "sourceRoot": "apps\\angular-ssr-prerendering-bug\\src",
      "prefix": "app",
      "architect": {
        "build": {
          "builder": "@angular-devkit/build-angular:browser",
          "options": {
            "outputPath": "dist\\apps\\angular-ssr-prerendering-bug",
            "index": "apps/angular-ssr-prerendering-bug/src/index.html",
            "main": "apps/angular-ssr-prerendering-bug/src/main.ts",
            "polyfills": "apps/angular-ssr-prerendering-bug/src/polyfills.ts",
            "tsConfig": "apps\\angular-ssr-prerendering-bug\\tsconfig.app.json",

Technically the config file only supports unix-style paths. But we don't enforce it, and in most places just silently accept the windows-style paths.

filipesilva · 2020-01-30T18:32:28Z

@SachinShekhar by the way, how did you get those paths? Did you add them yourself, or were they generated automatically by CLI, or even by Nx?

SachinShekhar · 2020-01-30T23:05:37Z

@filipesilva Those paths were generated automatically by CLI.
ng new angular-ssr-prerendering-bug
(global @angular/cli is latest v9)

filipesilva · 2020-01-31T00:01:14Z

@SachinShekhar do you remember what the commands were that generated the paths with \\? We really shouldn't be doing those.

I see them in the SachinShekhar/angular-ssr-prerendering-bug@593f599 commit but don't know what made them. I don't think we have a command that would change the paths for an existing app after ng new.

SachinShekhar · 2020-01-31T00:13:47Z

@filipesilva Oh, I see it was updated later.

I strongly believe ng add @nrwl/workspace is culprit then. NX brings the main app from src directory to apps/{project-name}, so it has to update the path.

filipesilva · 2020-01-31T09:37:22Z

@SachinShekhar ah I see! @FrozenPandaz heya, if Nx is writing windows paths in angular.json, can you switch that over to always writing unix paths please?

Fix angular#16800

FrozenPandaz · 2020-01-31T22:04:21Z

I made the fix :) ^

filipesilva · 2020-01-31T23:09:25Z

Awesome, thanks @FrozenPandaz! Also have a fix of our own for the migrations incoming.

Fix #16800

angular-automatic-lock-bot · 2020-03-06T08:04:25Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

gkalpak transferred this issue from angular/angular Jan 30, 2020

IgorMinar added this to the v9-candidates milestone Jan 30, 2020

ngbot bot removed this from the v9-candidates milestone Jan 30, 2020

filipesilva added area: schematics/angular freq2: medium severity5: regression type: bug/fix labels Jan 30, 2020

ngbot bot modified the milestone: Backlog Jan 30, 2020

filipesilva modified the milestones: Backlog, v9-candidates Jan 30, 2020

filipesilva self-assigned this Jan 30, 2020

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jan 31, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

2c3c841

Fix angular#16800

filipesilva mentioned this issue Jan 31, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration #16807

Merged

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jan 31, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

b5c19da

Fix angular#16800

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jan 31, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

29561fd

Fix angular#16800

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Jan 31, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

74e16dd

Fix angular#16800

FrozenPandaz mentioned this issue Jan 31, 2020

fix(misc): fix paths for ng add @nrwl/workspace nrwl/nx#2413

Merged

mgechev closed this as completed in #16807 Feb 4, 2020

mgechev pushed a commit that referenced this issue Feb 4, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

216af23

Fix #16800

mgechev pushed a commit that referenced this issue Feb 4, 2020

fix(@schematics/angular): resolve windows paths in tsconfig migration

d9119f6

Fix #16800

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng update wrote wrong path of main.ts and polyfill.ts in tsconfig.app.json #16800

ng update wrote wrong path of main.ts and polyfill.ts in tsconfig.app.json #16800

SachinShekhar commented Jan 30, 2020

filipesilva commented Jan 30, 2020

filipesilva commented Jan 30, 2020

SachinShekhar commented Jan 30, 2020

filipesilva commented Jan 31, 2020

SachinShekhar commented Jan 31, 2020 •

edited

filipesilva commented Jan 31, 2020 •

edited

FrozenPandaz commented Jan 31, 2020 •

edited

filipesilva commented Jan 31, 2020

angular-automatic-lock-bot bot commented Mar 6, 2020

ng update wrote wrong path of main.ts and polyfill.ts in tsconfig.app.json #16800

ng update wrote wrong path of main.ts and polyfill.ts in tsconfig.app.json #16800

Comments

SachinShekhar commented Jan 30, 2020

🐞 bug report

Affected Package

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

filipesilva commented Jan 30, 2020

filipesilva commented Jan 30, 2020

SachinShekhar commented Jan 30, 2020

filipesilva commented Jan 31, 2020

SachinShekhar commented Jan 31, 2020 • edited

filipesilva commented Jan 31, 2020 • edited

FrozenPandaz commented Jan 31, 2020 • edited

filipesilva commented Jan 31, 2020

angular-automatic-lock-bot bot commented Mar 6, 2020

SachinShekhar commented Jan 31, 2020 •

edited

filipesilva commented Jan 31, 2020 •

edited

FrozenPandaz commented Jan 31, 2020 •

edited