Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated dependency: request@2.88.2 #16952

Closed
petebacondarwin opened this issue Feb 12, 2020 · 18 comments · Fixed by #20075
Closed

deprecated dependency: request@2.88.2 #16952

petebacondarwin opened this issue Feb 12, 2020 · 18 comments · Fixed by #20075

Comments

@petebacondarwin
Copy link
Member

It appears that this version, which is deprecated is being pulled in by @angular/cli (via universal-analytics). I assume a bump to the latter's version will be enough to fix this?

You can see this warning when doing a fresh install of CLI@9.0.1:

warning @angular/cli > universal-analytics > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
@wartab
Copy link

wartab commented Feb 12, 2020

The paackage request is now fully deprecated. So that will probably take a while to change.

@petebacondarwin
Copy link
Member Author

Yes, I think the solution would be for universal-analytics to release a new version that is not reliant upon request.

@AURZeeshan
Copy link

problem ! request@2.88.2..

what are the alternative of it ?

@BruneXX
Copy link

BruneXX commented Mar 16, 2020

Hi, any update on this? thanks!

@khalidsheet
Copy link

@BruneXX
Me too, I'm waiting for a fix or something

@BruneXX
Copy link

BruneXX commented Mar 17, 2020

I think we'll need to check here: request/request#3142

@smoncadav
Copy link

I'm also getting this issue when installing angular CLI

npm install -g @angular/cli
npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142

@akhilh2o
Copy link

I'm also waiting for this solution===>

npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
C:\Users\hp\AppData\Roaming\npm\ng -> C:\Users\hp\AppData\Roaming\npm\node_modules@angular\cli\bin\ng

@angular/cli@9.1.1 postinstall C:\Users\hp\AppData\Roaming\npm\node_modules@angular\cli
node ./bin/postinstall/script.js

? Would you like to share anonymous usage data with the Angular Team at Google under
Google’s Privacy Policy at https://policies.google.com/privacy? For more details and
how to change this setting, see http://angular.io/analytics. No

  • @angular/cli@9.1.1
    added 272 packages from 207 contributors in 341.271s

@Serine18
Copy link

i have the same probleme,has any one found a solution

npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
C:\Users\pc pro\AppData\Roaming\npm\ng -> C:\Users\pc pro\AppData\Roaming\npm\node_modules@angular\cli\bin\ng

@alan-agius4
Copy link
Collaborator

This is currently blocked as it requires an upstream change.

peaksandpies/universal-analytics#143

@fToledo29
Copy link

Any updates about this issue?

@Serine18
Copy link

Serine18 commented Apr 22, 2020 via email

@jburson
Copy link

jburson commented Apr 28, 2020

@beeman
Copy link
Contributor

beeman commented May 6, 2020

I submitted a PR to peaksandpies/universal-analytics but the last commit to that project was 1.5 year ago so I doubt it will land anytime soon. Also, while upgrading said project, I got blocked on one of the unit tests (see PR).

@alan-agius4
Copy link
Collaborator

Closed via #18113

@alan-agius4
Copy link
Collaborator

Reopening since this was reverted in #18173

@alan-agius4 alan-agius4 reopened this Jul 7, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 28, 2021

Discussed this issue in CLI triage this week. The universal-analytics library unfortunately is not consistently maintained and landing this change has encountered some difficulties. We could try to push through a fix there, but dependencies bring their own costs and continuing to rely on something with little to no maintenance will bring its own problems.

There are unfortunately not many alternatives. Google Analytics doesn't appear to have an officially supported NodeJS SDK (aside from reporting APIs that don't apply here). Using other analytics platforms would open privacy and policy issues that we would rather avoid at the moment.

Instead, we think it's easier to just roll our own small implementation for the CLI. Google Analytics has an officially documented protocol which we can implement with simple HTTP requests. This appears to be how universal-analytics is implemented anyways. We don't need anything too complex for the CLI, just basic event tracking, so this can be pretty narrowly scoped. The main advantage here is that we should be able to drop an unmaintained dependency and not have to rely on it going forward.

clydin pushed a commit that referenced this issue Mar 1, 2021
With this change we remove the dependency on the unmaintained universal-analytics package. We also solve several package deprecation warnings when creating a new workspace.

Closes #16952
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.