Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy app on gh-pages on a custom domain #1781

Closed
rishabhsethi opened this issue Aug 20, 2016 · 5 comments
Closed

Deploy app on gh-pages on a custom domain #1781

rishabhsethi opened this issue Aug 20, 2016 · 5 comments
Labels
help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@rishabhsethi
Copy link

  1. OS: Ubuntu (15.10)
  2. Versions: 1.0.0-beta.10
  3. Repro steps:
    ng new app-name
    git add --all
    git remote add origin https://github.com/USERNAME/PROJECT_NAME.git
    git commit -m "message"
    git push origin master
    ng github-pages:deploy
  4. The app is deployed at https://username.github.io/app-name but I wish to deploy this app with a custom domain name. On the custom domain name, it is just showing "Loading...".
    I tried adding a CNAME file as well as setting the custom domain in the github repo settings.

Thanks!
@filipesilva filipesilva added type: enhancement P5 The team acknowledges the request but does not plan to address it, it remains open for discussion help wanted labels Aug 23, 2016
@filipesilva
Copy link
Contributor

We don't have this functionality yet, unfortunately.

@austingreendev
Copy link
Contributor

I don't see any open PR's for this yet so I will take a look at this as long as it is still a community item?

This was referenced Dec 5, 2016
Closed
Merged
@bigOconstant
Copy link

+1. Would really like this functionality added

filipesilva pushed a commit that referenced this issue Jan 13, 2017
@austingreendev @filipesilva
feat(deploy): add custom-domain support for gh-pages deployment (#1781)…
a54bc16 
… (#3392)

Creates CNAME file if --custom-domain flag is provided.

addresses (#1781)
@filipesilva
Copy link
Contributor

Closed via #4385.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@austingreendev @MRHarrison
feat(deploy): add custom-domain support for gh-pages deployment (angu…
44127a0 
…lar#1781) (angular#3392)

Creates CNAME file if --custom-domain flag is provided.

addresses (angular#1781)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bigOconstant @austingreendev @filipesilva @rishabhsethi