Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics reports only contains options passed via the command line #17900

Closed
alan-agius4 opened this issue Jun 10, 2020 · 1 comment · Fixed by #18982
Closed

Analytics reports only contains options passed via the command line #17900

alan-agius4 opened this issue Jun 10, 2020 · 1 comment · Fixed by #18982
Assignees
@alan-agius4
Labels
area: angular/cli freq3: high hotlist: devRel severity3: broken type: bug/fix
Milestone
Backlog

Comments

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Jun 10, 2020 •
edited

🐞 Bug report

Is this a regression?

No

Description

At the moment reportAnalytics is called outside of run this has a side effect of only sending options that are used in the command line and are non leftovers. Which results in a lot of data being not being sent to Google Analytics.

angular-cli/packages/angular/cli/models/command.ts

Lines 183 to 184 in b630317

await this.reportAnalytics([this.description.name], options);
const result = await this.run(options);

Reasons:

  1. Most of Schematics options are leftovers example:
{ dryRun: true, schematic: 'c', '--': [ 'baz', '--style', 'css' ] }

  1. Values defined in angular.json or via prompts are ignored and not sent.

  2. Option parsing and merging happen during the run.

🔥 Exception or Error

None

🌍 Your Environment

All versions
@ngbot ngbot bot added this to the Backlog milestone Jun 10, 2020
@alan-agius4 alan-agius4 self-assigned this Oct 6, 2020
@alan-agius4 alan-agius4 mentioned this issue Oct 6, 2020
Merged
clydin pushed a commit that referenced this issue Oct 7, 2020
@alan-agius4 @clydin
fix(@angular/cli): collect analytics option usage from workspace conf…
90988aa 
…ig and prompts

With this change we fix two analytics collection bugs:
- We now collect the usage of options defined in the workspace config (angular.json).
- We now also collect values set via schematic prompts.

Closes: #17900
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: angular/cli freq3: high hotlist: devRel severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): collect analytics option usage from workspace config and prompts
1 participant
@alan-agius4