Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "parent" value in schematics action.ts #18446

Closed
Seairth opened this issue Aug 4, 2020 · 2 comments · Fixed by #18449
Closed

Incorrect "parent" value in schematics action.ts #18446

Seairth opened this issue Aug 4, 2020 · 2 comments · Fixed by #18449
Labels
area: devkit/schematics freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone
Backlog

Comments

@Seairth
Copy link

Seairth commented Aug 4, 2020

While reading through the code, I came across this line:

https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/schematics/src/tree/action.ts#L37

When the _actions array is not empty, the parent field of the new action is being set to an object, not a number.
@alan-agius4 alan-agius4 added area: devkit/schematics freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix labels Aug 4, 2020
@ngbot ngbot bot added this to the Backlog milestone Aug 4, 2020
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Aug 4, 2020 •
edited

@Seairth, nice catch!

@alan-agius4 alan-agius4 mentioned this issue Aug 5, 2020
Merged
clydin pushed a commit that referenced this issue Aug 5, 2020
@alan-agius4 @clydin
fix(@angular-devkit/schematics): set correct parent id in actions lists
35c13a6 
Closes #18446
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: devkit/schematics freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@angular-devkit/schematics): set correct parent id in actions lists
2 participants
@Seairth @alan-agius4