Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AoT compilation by ignoring genDir #2849

Closed
robwormald opened this issue Oct 23, 2016 · 2 comments
Closed

Simplify AoT compilation by ignoring genDir #2849

robwormald opened this issue Oct 23, 2016 · 2 comments
Assignees
@hansl

Comments

@robwormald
Copy link
Contributor

Given the AoT plugin no longer writes generated code to disk, allowing a developer to set the genDir for code generation adds a huge amount of complexity to lazy module resolution.

We should simply assume that the generated code ends up in the (virtual) filesystem as a sibling to the original file, and thus resolving for ngfactory code should require simply appending .ngfactory to the path.
@hansl
Copy link
Contributor

hansl commented Oct 25, 2016

I'm going to remove the genDir option to the plugin entirely. There's absolutely no need for it.

hansl added a commit to hansl/angular-cli that referenced this issue Oct 25, 2016
@hansl
fix(aot): remove the genDir plugin option.
dbf2c8f 
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc.

Fixes angular#2849.
@hansl hansl mentioned this issue Oct 25, 2016
Closed
hansl added a commit to hansl/angular-cli that referenced this issue Oct 25, 2016
@hansl
fix(aot): remove the genDir plugin option.
797b336 
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc.

Fixes angular#2849.
hansl added a commit to hansl/angular-cli that referenced this issue Oct 27, 2016
@hansl
fix(aot): remove the genDir plugin option.
275333e 
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc.

Fixes angular#2849.
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@hansl @MRHarrison
fix(aot): remove the genDir plugin option.
72ea7fd 
We still consider the genDir property in the ngOptions of the tsconfig, to stay compatible with code that works with ngc.

Fixes angular#2849.
Close angular#2876
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hansl hansl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aot): remove the genDir plugin option. hansl/angular-cli
3 participants
@robwormald @hansl @filipesilva