Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in Contributing.md file #3153

Closed
CarreraPHP opened this issue Nov 16, 2016 · 3 comments
Closed

Broken link in Contributing.md file #3153

CarreraPHP opened this issue Nov 16, 2016 · 3 comments

Comments

@CarreraPHP
Copy link
Contributor

The link for google's javascript guide line is broken in Coding Rules Block.

url: http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml
@valorkin
Copy link
Contributor

Nice reason for small PR

@CarreraPHP
Copy link
Contributor Author

@valorkin , Thanks for the encouragement. pull request #3171 has been submitted for the same.

@CarreraPHP CarreraPHP mentioned this issue Nov 22, 2016
Closed
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this issue Feb 9, 2017
@CarreraPHP @MRHarrison
chore(contributing): update the javascript style guide url
cf1248d 
update the javascript style guide url from googlecode to github

Fix angular#3153
Close angular#3171
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(contributing): update the javascript style guide url CarreraPHP/angular-cli
2 participants
@CarreraPHP @valorkin