Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections to Angular CLI RC.0 migration guide #5039

Closed
PlatinumEagle opened this issue Feb 27, 2017 · 3 comments
Closed

Corrections to Angular CLI RC.0 migration guide #5039

PlatinumEagle opened this issue Feb 27, 2017 · 3 comments

Comments

@PlatinumEagle
Copy link
Contributor

PlatinumEagle commented Feb 27, 2017 •
edited

Versions

angular-cli v1.0.0-rc.0

Repro steps

Original application created with v1.0.0-beta.26, followed the guide to migrate to RC.0, but there are some corrections that need to be made for a successful migration.

Details

package.json corrections

  • Typo: Packages in dependencies: is listed twice. The second instance should be Packages in devDependencies:
  • The guide indicates that the jasmine-spec-reporter should be removed from devDependencies, but is still required and the version was updated to ~3.2.0.
  • The 'build' option is missing from "scripts". "build": "ng build" should be added.
  • ts-helpers was removed, but there is no reference to this in the doc
PlatinumEagle added a commit to PlatinumEagle/angular-cli that referenced this issue Feb 27, 2017
@PlatinumEagle
docs: correct rc.0 migration guide
0ca34bb 
fix test runner dependency and other corrections

Closes angular#5039
@PlatinumEagle PlatinumEagle mentioned this issue Feb 27, 2017
Closed
@PlatinumEagle
Copy link
Contributor Author

PlatinumEagle commented Feb 27, 2017 •
edited

PR submitted

PlatinumEagle added a commit to PlatinumEagle/angular-cli that referenced this issue Mar 2, 2017
@PlatinumEagle @robm-sentinelda
docs: correct rc.0 migration guide
bec21f8 
fix test runner dependency and other corrections

Closes angular#5039
@magnattic
Copy link

I tripped over the removal of jasmine-spec-reporter while following the upgrade guide. Turns out it is still needed for protractor.

PlatinumEagle pushed a commit to PlatinumEagle/angular-cli that referenced this issue Mar 3, 2017
@robm-sentinelda
docs: correct rc migration guide
e7d886b 
fix test runner dependency and other minor corrections

Closes angular#5039
PlatinumEagle added a commit to PlatinumEagle/angular-cli that referenced this issue Mar 3, 2017
@PlatinumEagle
docs: correct rc migration guide
1a5dd9f 
fix test runner dependency and other corrections

Closes angular#5039
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@PlatinumEagle
docs: correct rc migration guide
1b3b46a 
fix test runner dependency and other corrections

Closes angular#5039
Close angular#5041
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: correct rc.0 migration guide PlatinumEagle/angular-cli
2 participants
@PlatinumEagle @magnattic