Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the cli should check npm "dependencies" for the version #5112

Closed
ocombe opened this issue Feb 28, 2017 · 1 comment · Fixed by #5498
Closed

the cli should check npm "dependencies" for the version #5112

ocombe opened this issue Feb 28, 2017 · 1 comment · Fixed by #5498

Comments

@ocombe
Copy link
Contributor

ocombe commented Feb 28, 2017

I just updated a project to rc.0 but I still got the warning saying that I should update it. This is because in my project the cli is added as a dependency and not a devDependency... Changing that gets rid of the warning.
I think that it should check both for the cli version, not just devDependency.

OS?

Windows 10

Versions.

1.0.0-rc.0

Repro steps.

Add the cli as a dependency in package.json instead of devDependency

The log given by the failure.

The package "angular-cli" has been renamed to "@angular/cli". The old package will be deprecated soon.

Please take the following steps to avoid issues:
"npm install --save-dev @angular/cli@latest"
@ocombe ocombe mentioned this issue Feb 28, 2017
Merged
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 18, 2017
@delasteve
docs(@angular/cli): update warning message when @angular/cli not foun…
d4b8611 
…d in devDependencies

fixes angular#5112
@delasteve delasteve mentioned this issue Mar 18, 2017
Merged
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 18, 2017
@delasteve
fix(@angular/cli): update warning message when @angular/cli not found…
930b96f 
… in devDependencies

fixes angular#5112
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 19, 2017
@delasteve
fix(@angular/cli): update warning message when @angular/cli not found…
42a2400 
… in devDependencies

fixes angular#5112
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 19, 2017
@delasteve
fix(@angular/cli): update warning message when @angular/cli not found…
76330fe 
… in devDependencies

fixes angular#5112
hansl pushed a commit that referenced this issue Mar 21, 2017
@delasteve @hansl
fix(@angular/cli): update warning message when @angular/cli not found…
8a2b48c 
… in devDependencies

fixes #5112
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ocombe