Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comments in tsconfig referenced in AotPlugin conf #5216

Closed
csentis opened this issue Mar 4, 2017 · 2 comments
Closed

Allow comments in tsconfig referenced in AotPlugin conf #5216

csentis opened this issue Mar 4, 2017 · 2 comments
Labels
feature Issue that requests a new feature

Comments

@csentis
Copy link

csentis commented Mar 4, 2017

OS?

Windows 10

Versions.

node @ v7.5.0

Repro steps.

This happens in an app that wasn't created using the CLI.

  • Provide AotPlugin with tsConfigPath
  • tsconfig.json referenced has comments starting with '//' in it.
  • AotPlugin throws error due to unexpected token '/'.

MS allows for comments in tsconfig, Would be great if ngtools supported this, too.
@hansl hansl assigned sumitarora and unassigned sumitarora Mar 4, 2017
@hansl
Copy link
Contributor

hansl commented Mar 4, 2017

@sumitarora This is not for 1.0. Sorry for the mis-assignment. For now let's push this one further down the road.

@hansl hansl added the feature Issue that requests a new feature label Mar 4, 2017
@clydin clydin mentioned this issue Mar 5, 2017
Closed
@csentis csentis mentioned this issue May 8, 2017
Closed
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@dond2clouds
fix(@ngtools/webpack): allow comments in tsconfig files
a565ff6 
Close angular#5216
Close angular#5230
@CSchulz CSchulz mentioned this issue Jan 17, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@ngtools/webpack): allow comments in tsconfig files
3 participants
@sumitarora @hansl @csentis