Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployUrl not bound correctly #5254

Closed
es-lab opened this issue Mar 6, 2017 · 2 comments · Fixed by #5372
Closed

deployUrl not bound correctly #5254

es-lab opened this issue Mar 6, 2017 · 2 comments · Fixed by #5372
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@es-lab
Copy link

es-lab commented Mar 6, 2017

OS?

macOS Sierra

Versions.

@angular/cli: 1.0.0-rc.1
node: 7.7.1
os: darwin x64
@angular/common: 2.4.9
@angular/compiler: 2.4.9
@angular/core: 2.4.9
@angular/forms: 2.4.9
@angular/http: 2.4.9
@angular/platform-browser: 2.4.9
@angular/platform-browser-dynamic: 2.4.9
@angular/router: 3.4.9
@angular/cli: 1.0.0-rc.1
@angular/compiler-cli: 2.4.9

Repro steps.

Build with ng build -prod -deploy-url=http://sub.domain.com/.
In css files the links for images/fonts/etc.. are set like this: /http:/sub.domain/com/assets/....
The browsers tries to load the following url: http://domain.com/http:/sub.domain/com/assets/...

Mention any other details that might be useful.

My assets and every additional file but the index.html are served from http://sub.domain.com/ because of my backend. When I was using version beta26, setting deployUrl=http://sub.domain.com/ worked for files inside the index.html (but not for the favicon, this is an issue still in rc1, please put the deployUrl for the favicon too!). There were still issues with imgs, and other assets, a workaround was loading them through css, but this worked only if loading them in the style that was loaded form the subdomain, images loaded from inline style still failed.
Now with rc1 I see that you put the deployUrl in styles too, this is good, but it works only for path prefixes, not entire hosts like in my use case.

@filipesilva filipesilva self-assigned this Mar 10, 2017
@filipesilva filipesilva added command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix labels Mar 10, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 10, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 10, 2017
@filipesilva
Copy link
Contributor

Heya, I'm fixing the deployUrl behaviour with a full URL on #5372.

Regarding favicon, that's up to you to configure really... it's just listed in index.html, and you can change it.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 13, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 13, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 13, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 13, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Mar 13, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
2 participants