Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AOT Webpack Plugin doesn't seem to find errors; ex. for non-public property rule in template #5264

Closed
jimbarrett33 opened this issue Mar 7, 2017 · 3 comments
Closed

AOT Webpack Plugin doesn't seem to find errors; ex. for non-public property rule in template #5264

jimbarrett33 opened this issue Mar 7, 2017 · 3 comments
Labels
needs: more info Reporter must clarify the issue

Comments

@jimbarrett33
Copy link

jimbarrett33 commented Mar 7, 2017 •
edited

Please provide us with the following information:

OS?

Windows 10

Versions.

@angular/cli: 1.0.0-rc.1
node: 6.9.4
os: win32 x64
@angular/common: 2.4.5
@angular/compiler: 2.4.5
@angular/compiler-cli: 2.4.9
@angular/core: 2.4.5
@angular/forms: 2.4.5
@angular/http: 2.4.5
@angular/platform-browser: 2.4.5
@angular/platform-browser-dynamic: 2.4.5
@angular/platform-server: 2.4.9
@angular/router: 3.4.5
@ngtools/webpack: 1.2.12

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
No, the app wasn't created with CLI. It is using AOT webpack plugin

The log given by the failure.

Well, it's sort of lack of trace/log but I am expecting to see things like below which is what I get if I try to build with ngc directly.

user-login.component.ngfactory.ts:439:48: Property 'UserName' does not exist on type 'UserLoginComponent'.

Mention any other details that might be useful.

I thought all template properties need to exist and be public in the component code. I do get errors in when running the AOT build but I thought they would be caught by the AOT compile. Maybe I don't understand the rules for AOT or the rules have been relaxed or somehow the AOT Webpack plugin is fixing the problem.

Thanks.

Thanks! We'll be in touch soon.
@filipesilva
Copy link
Contributor

@hansl can you weigh in?

@filipesilva filipesilva added the needs: more info Reporter must clarify the issue label Mar 17, 2017
@StephenFluin
Copy link
Contributor

It looks like we're silencing any AOT errors.

Repro: https://github.com/StephenFluin/2017-03-22-repro-cli-silent-aot-errors

cc @hansl @robwormald

hansl added a commit to hansl/angular-cli that referenced this issue Mar 23, 2017
@hansl
fix(@ngtools/webpack): diagnose generated files and resolve sourcemaps
90f1c7c 
Generated files were not diagnosed in AOT which led to errors not being shown properly. Also,
in order to show the proper error source we now resolve the sourcemap of any errors we find.

Fixes angular#5264
Fixed angular#4538
@hansl hansl closed this as completed in 5acf10b Mar 24, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs: more info Reporter must clarify the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StephenFluin @hansl @filipesilva @jimbarrett33