Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: document --prod and add minification flag #5315

Closed
filipesilva opened this issue Mar 8, 2017 · 4 comments · Fixed by #6232
Closed

Tracking: document --prod and add minification flag #5315

filipesilva opened this issue Mar 8, 2017 · 4 comments · Fixed by #6232
Assignees
Labels
area: docs Related to the documentation P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@filipesilva
Copy link
Contributor

filipesilva commented Mar 8, 2017

We should document what --prod really does.

It's actually a sort of meta-flag that adds a bunch of defaults: https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/models/webpack-config.ts#L84-L89

Besides setting these defaults, it also adds minification and a few more things: https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/models/webpack-configs/production.ts#L85-L93

Minification should perhaps be opt-in however, via a flag.

@johnnliu
Copy link

I was able to figure out that --prod seem to have done AOT and -environment=prod but wasn't sure what else it did.

The really shocking part was actually that I find the documentation missing and that filled me with worry.

Thanks for clarifications on twitter.

@filipesilva filipesilva added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Mar 23, 2017
@sumitarora
Copy link
Contributor

@filipesilva we can add that in build command wiki ?

@filipesilva
Copy link
Contributor Author

@sumitarora I'm adding the docs bit in #6232, can you add the minification flag while you're fixing the UglifyJS problems you are working on?

filipesilva added a commit to filipesilva/angular-cli that referenced this issue May 9, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue May 9, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue May 9, 2017
hansl pushed a commit that referenced this issue May 9, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants