Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dry run updates module with -m flag #5862

Closed
jdell64 opened this issue Apr 6, 2017 · 1 comment · Fixed by #5884
Closed

Dry run updates module with -m flag #5862

jdell64 opened this issue Apr 6, 2017 · 1 comment · Fixed by #5884

Comments

@jdell64
Copy link

jdell64 commented Apr 6, 2017 •
edited

Bug Report or Feature Request (mark with an x)

- [ x] bug report -> please search issues before submitting (I did)
- [ ] feature request

Versions.

@angular/cli: 1.0.0
node: 7.7.3
os: darwin x64
@angular/common: 4.0.1
@angular/compiler: 4.0.1
@angular/core: 4.0.1
@angular/forms: 4.0.1
@angular/http: 4.0.1
@angular/platform-browser: 4.0.1
@angular/platform-browser-dynamic: 4.0.1
@angular/router: 4.0.1
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.1
  
macOS Sierra

Repro steps.

50-207-252-218-static:angular-tour-of-heroes jeff$ ng g s data -m app.module -d
installing service
You specified the dry-run flag, so no changes will be written.
  create src/app/data.service.spec.ts
  create src/app/data.service.ts
  update src/app/app.module.ts

The log given by the failure.

The update src/app/app.module.ts file was updated even though the dry run flag was specified.

Desired functionality.

To not update.

Seems to be just the -d flag on services.
@hansl hansl self-assigned this Apr 6, 2017
@sumitarora sumitarora self-assigned this Apr 7, 2017
hansl added a commit to hansl/angular-cli that referenced this issue Apr 7, 2017
@hansl
fix(@angular/cli): generating service dry run fix
8d92b80 
Before, generating a service and providing it in a module, the dry run flag was
ignored for the providing part. We dont provide the module now if its a dry-run.

Fixes angular#5862.
@hansl hansl mentioned this issue Apr 7, 2017
Merged
hansl added a commit that referenced this issue Apr 11, 2017
@hansl
fix(@angular/cli): generating service dry run fix
be7c9b1 
Before, generating a service and providing it in a module, the dry run flag was
ignored for the providing part. We dont provide the module now if its a dry-run.

Fixes #5862.
@sumitarora sumitarora mentioned this issue Apr 22, 2017
Closed
hansl added a commit that referenced this issue Apr 25, 2017
@hansl
fix(@angular/cli): generating service dry run fix
f5602ee 
Before, generating a service and providing it in a module, the dry run flag was
ignored for the providing part. We dont provide the module now if its a dry-run.

Fixes #5862.
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@hansl @dond2clouds
fix(@angular/cli): generating service dry run fix
bca4bb6 
Before, generating a service and providing it in a module, the dry run flag was
ignored for the providing part. We dont provide the module now if its a dry-run.

Fixes angular#5862.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): generating service dry run fix hansl/angular-cli
3 participants
@sumitarora @hansl @jdell64