Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy proxy config with defaults or inline #6240

Closed
1 of 2 tasks
xealot opened this issue May 9, 2017 · 4 comments
Closed
1 of 2 tasks

Easy proxy config with defaults or inline #6240

xealot opened this issue May 9, 2017 · 4 comments
Labels
effort1: easy (hours) feature Issue that requests a new feature help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@xealot
Copy link

xealot commented May 9, 2017

Bug Report or Feature Request

  • bug report -> please search issues before submitting
  • feature request

Versions.

@angular/cli: 1.0.2
node: 7.9.0
os: darwin x64
@angular/animations: 4.1.0
@angular/common: 4.1.0
@angular/compiler: 4.1.0
@angular/core: 4.1.0
@angular/forms: 4.1.0
@angular/http: 4.1.0
@angular/platform-browser: 4.1.0
@angular/platform-browser-dynamic: 4.1.0
@angular/router: 4.1.0
@angular/cli: 1.0.2
@angular/compiler-cli: 4.1.0

Desired functionality.

Level 1
Allow us to specify --proxy-conf command line flag through .angular-cli.json defaults mechanism.

Level 2
Allow inlining of proxy config into .angular-cli.json to reduce the amount of files in the root.
@filipesilva
Copy link
Contributor

I think the first bit is a useful setting for projects that always need to be ran with that proxy. I'd prefer not to inline it though, since it can also be a .js file and it could massively complicate the CLI json file schema.

@filipesilva filipesilva added help wanted effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion feature Issue that requests a new feature labels May 10, 2017
ayvazj added a commit to ayvazj/angular-cli that referenced this issue May 28, 2017
@ayvazj
feat(@angular/cli): read proxyConfig from angular-cli.json
7466b91 
easy proxy config by reading default from angular-cli.json (angular#6240)
@ayvazj ayvazj mentioned this issue May 28, 2017
Merged
@ayvazj
Copy link
Contributor

ayvazj commented May 28, 2017

I submitted a PR for this HTH #6493

ayvazj added a commit to ayvazj/angular-cli that referenced this issue Jun 3, 2017
@ayvazj
feat(@angular/cli): read proxyConfig from angular-cli.json
d0b03ca 
easy proxy config by reading default from angular-cli.json (angular#6240)
ayvazj added a commit to ayvazj/angular-cli that referenced this issue Jun 3, 2017
@ayvazj
feat(@angular/cli): read proxyConfig from angular-cli.json
85e6daf 
easy proxy config by reading default from angular-cli.json (angular#6240)
ayvazj added a commit to ayvazj/angular-cli that referenced this issue Jun 3, 2017
@ayvazj
feat(@angular/cli): read proxyConfig from angular-cli.json
fe43113 
easy proxy config by reading default from angular-cli.json (angular#6240)
ayvazj added a commit to ayvazj/angular-cli that referenced this issue Jul 4, 2017
@ayvazj
feat(@angular/cli): read proxyConfig from angular-cli.json
e8ea6e2 
easy proxy config by reading default from angular-cli.json (angular#6240)
hansl pushed a commit that referenced this issue Jul 5, 2017
@ayvazj @hansl
feat(@angular/cli): read proxyConfig from angular-cli.json
36e4d7b 
easy proxy config by reading default from angular-cli.json (#6240)
hansl pushed a commit that referenced this issue Jul 12, 2017
@ayvazj @hansl
feat(@angular/cli): read proxyConfig from angular-cli.json
af22242 
easy proxy config by reading default from angular-cli.json (#6240)
@shairez
Copy link
Contributor

shairez commented Jul 18, 2017

@hansl @Brocco This can be closed (it was already merged by #6493 )

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@ayvazj @dond2clouds
feat(@angular/cli): read proxyConfig from angular-cli.json
f0a975b 
easy proxy config by reading default from angular-cli.json (angular#6240)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort1: easy (hours) feature Issue that requests a new feature help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xealot @sumitarora @ayvazj @shairez @filipesilva