Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating assets requires a code recompilation #7521

Closed
intellix opened this issue Aug 27, 2017 · 4 comments · Fixed by #7600
Closed

Updating assets requires a code recompilation #7521

intellix opened this issue Aug 27, 2017 · 4 comments · Fixed by #7600
Assignees
@filipesilva
Labels
help wanted P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix

Comments

@intellix
Copy link
Contributor

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

node: 8.2.1
os: darwin x64
@angular/animations: 5.0.0-beta.4
@angular/cli: 1.4.0-rc.1
@angular/common: 5.0.0-beta.4
@angular/compiler: 5.0.0-beta.4
@angular/compiler-cli: 4.3.4
@angular/core: 5.0.0-beta.4
@angular/flex-layout: 2.0.0-beta.9
@angular/forms: 5.0.0-beta.4
@angular/http: 5.0.0-beta.4
@angular/platform-browser: 5.0.0-beta.4
@angular/platform-browser-dynamic: 5.0.0-beta.4
@angular/router: 5.0.0-beta.4
@angular/language-service: 4.3.4
typescript: 2.4.2

Repro steps.

  1. curl localhost:4200/assets/image.svg
  2. Change that image slightly and save it
  3. curl localhost:4200/assets/image.svg - will not show the change
  4. Save a file like app.component.ts
  5. curl localhost:4200/assets/image.svg - you'll see the change

Desired functionality.

Would like changes reflected without having to update a watched file. I'm currently debugging some weird SVG issues to do with feColorMatrix and was confused why changes weren't being shown. It wasn't until I saw the same issues in Firefox that I realised the problem was the server.
@savasayik
Copy link

+1

@dklmuc
Copy link

dklmuc commented Aug 29, 2017

I also think assets should trigger a reload. As far as I understand the webpack-dev-server is holding the files in RAM, so also a manually Browser Refresh wouldn't show new versions of the files in the assets folder. Therefor a restart of the CLI is mandatory, which hurts a lot with an initial startup time of e.g. 40 seconds.

Other use case besides @intellix SVG example:
Using ngx-translate with JSON files for the translations in the assets folder.

@filipesilva filipesilva self-assigned this Sep 4, 2017
@filipesilva filipesilva added help wanted P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix labels Sep 4, 2017
@filipesilva
Copy link
Contributor

This seems to be an unintended consequence of #7310, where another different bug was masking this bug.

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Sep 5, 2017
@filipesilva
fix(@angular/cli): fix asset watching
1bf9a7a 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix angular#7521
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Sep 5, 2017
@filipesilva
fix(@angular/cli): fix asset watching
0ac7524 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix angular#7521
@filipesilva filipesilva mentioned this issue Sep 5, 2017
Merged
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Sep 5, 2017
@filipesilva
fix(@angular/cli): fix asset watching
5cb7fc7 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix angular#7521
filipesilva added a commit that referenced this issue Sep 5, 2017
@filipesilva
fix(@angular/cli): fix asset watching
38a7ab4 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix #7521
filipesilva added a commit that referenced this issue Sep 6, 2017
@filipesilva
fix(@angular/cli): fix asset watching
feb7d0b 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix #7521
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@filipesilva @dond2clouds
fix(@angular/cli): fix asset watching
74739f3 
https://github.com/kevlened/copy-webpack-plugin is now used instead of the custom plugin, it has since implemented the features we needed.

Fix angular#7521
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@filipesilva filipesilva

Labels
help wanted P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@angular/cli): fix asset watching filipesilva/angular-cli
4 participants
@intellix @filipesilva @savasayik @dklmuc