fix($parse): Handle one-time to null

Handles when a one-time binding stabilizes to `null` Closes #7743 Closes #7787
angular · Jun 13, 2014 · 600a41a · 600a41a
1 parent 398053c
commit 600a41a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/ng/parse.js b/src/ng/parse.js
@@ -1055,7 +1055,8 @@ function $ParseProvider() {
             if (oneTimeParseFn.$$unwatch && self && self.$$postDigestQueue) {
               self.$$postDigestQueue.push(function () {
                 // create a copy if the value is defined and it is not a $sce value
-                if ((stable = isDefined(lastValue)) && !lastValue.$$unwrapTrustedValue) {
+                if ((stable = isDefined(lastValue)) &&
+                    (lastValue === null || !lastValue.$$unwrapTrustedValue)) {
                   lastValue = copy(lastValue, null);
                 }
               });

diff --git a/test/ng/parseSpec.js b/test/ng/parseSpec.js
@@ -1012,8 +1012,18 @@ describe('parser', function() {
 
           value.baz = 'baz';
           expect(fn()).toEqual({bar: 'bar'});
+        }));
 
+        it('should not throw if the stable value is `null`', inject(function($parse, $rootScope) {
+          var fn = $parse('::foo');
+          $rootScope.$watch(fn);
+          $rootScope.foo = null;
+          $rootScope.$digest();
+          $rootScope.foo = 'foo';
+          $rootScope.$digest();
+          expect(fn()).toEqual(null);
         }));
+
       });