-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Commit
angular.extend
that …
- Loading branch information
There are no files selected for viewing
6 comments
on commit c0498d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but it seems like this feature is not used in core. So is this just a convenience function? But aren't we telling people quite often that they shouldn't rely on these helper functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a minimal code change (with no breaking change), which happened to work better with a new method name rather than a less intuitive extra parameter. It is still harmless and adds only a few bytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can think of a dozen "harmless" utility functions, that only add a few bytes each, do not introcude a breaking change, are not used by the core and are potentially useful to someone.
The point is, it is contradictory to say "exposing these helper functions was a bad idea to start with, we shouldn't have done that, now let's add one more (that's not even used by the core; just in case someone needs it)".
I don't feel strongly about it, just confused 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. This sneaked in by presenting itself as a tiny harmless change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃
This parameter does not exist (any more).