fix(select): Fix several issues when moving options between groups #10166
Conversation
lgalfaso
commented
Nov 22, 2014
lgalfaso
commented
- When an option was moved to a previous group, the group that loose the option would remove the label from the controller
- When an entire option group was removed, the options in the group were mot removed from the controller
|
CLAs look good, thanks! |
| scope.mySelect = 'C'; | ||
| }); | ||
| expect(selectCtrl.hasOption('C')).toBe(true); | ||
| }); |
There was a problem hiding this comment.
two empty blanks betweets its please. one day we'll have a jscs rule for this :)
There was a problem hiding this comment.
this test is based on #10161 (at 1.3 this is working, but I will need to backport this to 1.2). Anyhow, will add the extra checks
lgalfaso
force-pushed
the
select-fixes
branch
from
4d11d5f
to
b69d8e3
Compare
|
updated the PR with the proposed changes |
|
@lgalfaso I've added it to the 1.3.5 milestone. Feel free to move it to 1.3.4 if you think it is close to being ready to merge. I'm restarting Travis to see what it thinks about your PR :-) (BTW, Travis is reallly flaky today...) |
|
@pkozlowski-opensource if I get a 👍 from a core member team, I would like to commit this for 1.3.4 (and backport it so it makes it to 1.2.28) |
| }); | ||
|
|
||
|
|
||
| it('should be able to detect when an element is replaced with an elements from a previous group', function() { |
There was a problem hiding this comment.
"an element" or "elements"?
|
I reviewed it too because I work on another select bug, and it's good practive in understanding this beast ;) |
* When an option was moved to a previous group, the group that loose the option would remove the label from the controller * When an entire option group was removed, the options in the group were mot removed from the controller
lgalfaso
force-pushed
the
select-fixes
branch
from
b69d8e3
to
d9a3a89
Compare
|
Updated the PR |
|
LGTM - I'll fix up that one |
