Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

@param docs missing for $routeChangeStart, $routeChange… #11418

Closed
fredsa opened this issue Mar 24, 2015 · 4 comments
Closed

@param docs missing for $routeChangeStart, $routeChange… #11418

fredsa opened this issue Mar 24, 2015 · 4 comments

Comments

@fredsa
Copy link
Contributor

fredsa commented Mar 24, 2015

See latest docs: https://docs.angularjs.org/api/ngRoute/service/$route
See latest source: https://github.com/angular/angular.js/edit/master/src/ngRoute/route.js

Note that $routeChangeStart, $routeChangeSuccess, $routeChangeError, $routeUpdate each have documented parameters (via @param), but these parameters are missing from the published docs.

@petebacondarwin petebacondarwin added this to the Backlog milestone Mar 25, 2015
@petebacondarwin
Copy link
Member

Feel free to send in further PRs for these docs @fredsa. Thanks

@Narretz
Copy link
Contributor

Narretz commented Jun 8, 2015

@petebacondarwin Actually this seems to be a systemic problem: the event params are also missing from location and ngInclude. Is it possible that dgeni is not rendering these?

@Narretz Narretz assigned petebacondarwin and unassigned Narretz Jun 9, 2015
@Narretz
Copy link
Contributor

Narretz commented Jun 9, 2015

@petebacondarwin It's not a dgeni issue yet, since I am not sure if it is actually a dgeni problem.

@petebacondarwin
Copy link
Member

The change has landed in dgeni-packages. Will update automatically when we publish the next version and update angular.js npm-shrinkwrap.

netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants