Transcluded content is not trimmed

[jjenzz]

When specifying an ng-transclude element, the documentation says you can provide a fallback that will render if no content is transcluded. However, if there is only whitespace in the transclusion slot it will replace the fallback with this whitespace.

I prefer to markup my components as follows:

<ns:legend-item
    ng-repeat="item in $ctrl.legendItems"
    ns:color="{{ item.color }}"
    ns:label="{{ item.name }}">
</ns:legend-item>

Doing it this way means it always passes some whitespace as the transcluded content and my fallback is removed. To fix I have to change the markup to:

<ns:legend-item
    ng-repeat="item in $ctrl.legendItems"
    ns:color="{{ item.color }}"
    ns:label="{{ item.name }}"></ns:legend-item>

It doesn't seem right that the position of the closing tag changes how the component renders.

I'm using Angular 1.5.5.

[rendisek70]

O

Dne 31. 8. 2016 16:16 napsal uživatel "Jenna Smith" <
notifications@github.com>:

When specifying an ng-transclude element, the documentation says you can
provide a fallback that will render if no content is transcluded. However,
if there is whitespace in the transclusion slot it will replace the
fallback with this whitespace.

I prefer to markup my components as follows:

<np:legend-item ng-repeat="item in $ctrl.legendItems" np:color="{{
item.color }}" np:label="{{ item.name }}"> /np:legend-item

Doing it this way means it always passes some whitespace as the
transcluded content and my fallback is removed. To fix I have to change the
markup to:

<np:legend-item ng-repeat="(key, item) in $ctrl.legendItems" np:color="{{
item.color }}" np:label="{{ key }}">/np:legend-item

It doesn't seem right that the position of the closing tag changes how
the component renders.

I'm using Angular 1.5.5.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Narretz]

It doesn't seem right that the position of the closing tag changes how the component renders.

This is how the DOM works. Whitespace and linebreaks create text nodes that contain only whitespace.

I guess it's unlikely that someone wants the current behavior, but iwe cannot say 100% that it isn't so. If you minfied your html you won't have this problem.

But we have to think about if there's a better way to handle this.

[jjenzz]

@Narretz: I do minify my HTML in production. However, during development everything appears broken so I'm having to avoid this approach.

I know how the DOM works, however, it seems strange that a project would require that a whitespace only transclude overrides the fallback. Of course, you can't say 100% that the current behaviour isn't what's wanted but what if the percentage it's wanted is a lot less than the percentage it isn't. It seems to render this fallback thing quite useless.

If we're concerned about keeping the way it behaves and not breaking existing code that might depend on current behaviour, could we make it optional somehow?

[petebacondarwin]

OK, so I think we should probably support trimming if the content is only whitespace.
But should we always trim front and back whitespace even if there is content? I think probably not.

[petebacondarwin]

Unfortunately as this would be a breaking change, we can't do it in 1.5.9. It will be in 1.6. But you can alway patch your version of 1.5.x to get the required behaviour until you upgrade to 1.6.

[petebacondarwin]

I have a PR for this #15140. Please take a look @jjenzz