This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngScenario): select(...).option(val) should select exact value match #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With select(...).option(val) it previously would select the first node which contains the value, even if an exact match was available. This fix prefers exact matches if available, otherwise it reverts to the previous 'contains' behaviour for backwards compatibility.
PR Checklist (Minor Feature)
|
|
@Smerity - have you signed the CLA? We need this before we can merge. |
|
Hi @petebacondarwin, I've indeed signed the online individual CLA under the name Stephen Merity using the email smerity@smerity.com =] |
|
Thanks @Smerity for your work on this PR. |
ctrahey
pushed a commit
to ctrahey/angular.js
that referenced
this pull request
Jul 22, 2013
With select(...).option(val) it previously would select the first node which contains the value, even if an exact match was available. This fix prefers exact matches if available, otherwise it reverts to the previous 'contains' behaviour for backwards compatibility. Closes angular#2856
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests modifies ngScenario's
select(...).option(val)such that it closes #2855.This fix prefers exact matches when available, otherwise it reverts to the previous 'contains' behaviour for backwards compatibility.
This pull request also updates the dslSpec tests to ensure proper behaviour going forward for both the exact text match and the :contains text match.