Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

q-fs is deprecated, use q-io/fs instead in doc generators #3244

Closed
ksheedlo opened this issue Jul 16, 2013 · 2 comments
Closed

q-fs is deprecated, use q-io/fs instead in doc generators #3244

ksheedlo opened this issue Jul 16, 2013 · 2 comments

Comments

@ksheedlo
Copy link
Contributor

From Pete's comment on #3235:

The q-fs npm module is now deprecated. We should be using q-io instead. This module contains the function makeTree (see http://documentup.com/kriskowal/q-io#filesystem/maketree-path-mode). I think we should upgrade the project to use this module instead of implementing our own algorithms, which would also need to have unit tests by the way :-)

We need to replace q-fs with q-io/fs. If it meets our needs with respect to building directories (see the later comment), then we should also replace writer.makeDir with q-io/fs.makeTree. If it doesn't, then we should at least include tests for writer.makeDir.

@btford btford added this to the Backlog milestone Mar 25, 2014
@evankroske
Copy link

It appears that we're not using q-fs anymore. Could you confirm this and close the bug?

@caitp
Copy link
Contributor

caitp commented Apr 22, 2014

This was dealt with by 18e0768 in core. I'm not sure anything in the tree needs q-fs, or q at all anymore. I'm wrong, i18n still wants q

@caitp caitp closed this as completed Apr 22, 2014
caitp added a commit to caitp/angular.js that referenced this issue Apr 22, 2014
Based on angular#3244 (comment), I don't believe
we actually use either of these now that dgeni has replaced the old docs app. These should be
removed if Travis is green.

The i18n scripts still rely on q, so unfortunately it can't be gotten rid of just yet.
caitp added a commit that referenced this issue Apr 22, 2014
Based on #3244 (comment), I don't believe
we actually use either of these now that dgeni has replaced the old docs app. These should be
removed if Travis is green.

The i18n scripts still rely on q, so unfortunately it can't be gotten rid of just yet.
caitp added a commit that referenced this issue Apr 22, 2014
Based on #3244 (comment), I don't believe
we actually use either of these now that dgeni has replaced the old docs app. These should be
removed if Travis is green.

The i18n scripts still rely on q, so unfortunately it can't be gotten rid of just yet.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants