Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Document (in release notes?) that attributes ending with "-start" and "-end" will no longer work #3589

Closed
alexandrosm opened this issue Aug 14, 2013 · 2 comments
Milestone

Comments

@alexandrosm
Copy link

Angular-timer uses an attribute called "auto-start" which stopped working with 1.2 due to e46100f .

Admittedly, this is a bit of a freak accident, but if it's not fixed as a bug (probably not worth it) it should be documented in the release notes that this will happen as it causes behaviour that's very hard to debug (had to git-bisect the angular codebase).

@IgorMinar
Copy link
Contributor

good point. thanks for bringing this up.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Sep 25, 2013
@stakach
Copy link

stakach commented Oct 4, 2013

@IgorMinar This also seems to effect attributes on directives too

<mydirective attr-start="startfunc()" attr-end="endfunc()"></mydirective>

then in the linking function

function link (scope, element, attrs) {
  attrs === {
    attr: startfunc,
    attrEnd: endfunc
  }
}

note that attr-end was not modified.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants