Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngsanitize problems with doctype #3931

Closed

Conversation

paolodm
Copy link
Contributor

@paolodm paolodm commented Sep 9, 2013

Fixes #902.

ngSanitize removes the doctype element.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@paolodm
Copy link
Contributor Author

paolodm commented Sep 9, 2013

Real Name: Paolo del Mundo

On Sun, Sep 8, 2013 at 10:23 PM, Mary Poppins notifications@github.comwrote:

Thanks for the PR!

  • Contributor signed CLAhttp://docs.angularjs.org/misc/contribute#CLAnow or in the past
  • If you just signed, leave a comment here with your real name
    • PR's commit messages follow the commit message formathttps://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#

If you need to make changes to your pull request, you can update the
commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!


Reply to this email directly or view it on GitHubhttps://github.com//pull/3931#issuecomment-24035562
.

Paolo del Mundo
Software Engineer
Opower
linkedin http://www.linkedin.com/in/paolodelmundo

@NickHeiner
Copy link
Contributor

👍

@ghost ghost assigned petebacondarwin Oct 2, 2013
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Oct 3, 2013
HTML to be sanitized that contains a DOCTYPE declaration were causing
the HTML parser to throw an error.  Now the parser correctly removes
the declarations when sanitizing HTML.

Closes angular#3931
@petebacondarwin
Copy link
Member

@paolodm - can you confirm that you did sign the CLA, we couldn't find your name in the list.

@paolodm
Copy link
Contributor Author

paolodm commented Oct 3, 2013

Yes, signed it awhile ago.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
HTML to be sanitized that contains a DOCTYPE declaration were causing
the HTML parser to throw an error.  Now the parser correctly removes
the declarations when sanitizing HTML.

Closes angular#3931
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
HTML to be sanitized that contains a DOCTYPE declaration were causing
the HTML parser to throw an error.  Now the parser correctly removes
the declarations when sanitizing HTML.

Closes angular#3931
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngSanitize fails to parse html with doctype
4 participants