Wrong cast to boolean

[zakjan]

toBoolean(window) === false

because of that toBoolean(value) function checks value.length property, which means for window the count of (i)frames - usually 0.

[petebacondarwin]

@zakjan - Can you give the context where this is causing problems?

[zakjan]

I found this when used ng-show="someVar", and in my case someVar can be a window object. So it is a very edge case.

Quick solution was to double-not (!!) someVar.

[leostera]

Should this be defaulted?

On Tue, Oct 8, 2013 at 7:56 AM, Jan Žák notifications@github.com wrote:

I found this when used ng-show="someVar", and in my case someVar can be a
window object. So it is a very edge case.

Quick solution was to double-not (!!) someVar.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4277#issuecomment-25880454
.

[petebacondarwin]

Hmm, well ng-show="[]" also hides the element, even though in the console

if([]) { console.log('true'); }
> "true"

[leostera]

This is where we are looking at:

angular.js/src/Angular.js

Line 863 in bed08c9

function toBoolean(value) {

It explicitly handles the "[]" case.

On Tue, Oct 8, 2013 at 9:52 AM, Pete Bacon Darwin
notifications@github.comwrote:

Hmm, well ng-show="[]" also hides the element, even though in the console

if([]) { console.log('true'); }> "true"

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4277#issuecomment-25886662
.

[zakjan]

So maybe the fix could be to separate array length check just for arrays:

if (isArray(value)) {
  value = value.length !== 0;
} else if ...

[capaj]

There is also another issue with functions: #5414