Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Make AngularJS compatible with jQuery 1.6.4 #556

Closed
IgorMinar opened this issue Sep 12, 2011 · 16 comments
Closed

Make AngularJS compatible with jQuery 1.6.4 #556

IgorMinar opened this issue Sep 12, 2011 · 16 comments
Assignees
Milestone

Comments

@IgorMinar
Copy link
Contributor

There are several reports that angular doesn't work well with jquery 1.6.3, we need to upgrade and rerun our unit/e2e tests and get things fixed.

Related mailing list threads:

UPDATE:

jQuery 1.6.4 was released with some regression fixes. We'll upgrade to 1.6.4 instead.

@ghost ghost assigned IgorMinar Sep 12, 2011
@IgorMinar
Copy link
Contributor Author

preliminary results after upgrade to 1.6.3

with jquery:

Total 981 tests (Passed: 970; Fails: 11; Errors: 0) (1017.00 ms)

with jqlite:

Total 981 tests (Passed: 977; Fails: 4; Errors: 0) (1422.00 ms)

@marcenuc
Copy link
Contributor

I'm not sure if it's important, however jQuery-1.6.3 has a few regressions fixed in jQuery-1.6.4.

@IgorMinar
Copy link
Contributor Author

thanks @marcenuc, fortunately I didn't spend too much time with 1.6.3, I'll upgrade straight to 1.6.4 instead.

IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Sep 15, 2011
@bartes
Copy link

bartes commented Oct 7, 2011

I'm not sure is directly related to that ticket but you have made reference here: http://groups.google.com/group/angular/browse_thread/thread/df7b0e34e2f215e8/4f60c90ddcbf42a2?lnk=gst&q=select+box#4f60c90ddcbf42a2.
Did you have a chance to check those problems with select inputs ?

@IgorMinar
Copy link
Contributor Author

it's fixed in master: http://jsfiddle.net/DNLt8/5/

I'll be cutting a release today.

@bartes
Copy link

bartes commented Oct 7, 2011

I still have got some issues with select box and jQuery 1.6.4 (I'm using build from master) . I'll make some investigations and give you a feedback on Monday. Wish you good release.

@IgorMinar
Copy link
Contributor Author

hmm.. ok.. let us know what doesn't work. ideally as a jsfiddle example.

@bartes
Copy link

bartes commented Oct 10, 2011

I don't now why but using select with ng:repeat was a problem with jQ 1.6.4 and it wasn't with 1.6.2 .After switching to ng:options all works fine. Thank you.

@IgorMinar
Copy link
Contributor Author

we gave up on the idea of supporting ng:repeat for options element. due to browser inconsistencies and other crazy complexities it's super hard to do it properly (I don't want to say impossible, but you can think of it that way).

@respectTheCode
Copy link

Im having problems with jQ 1.6.4 / angular 0.9.19 and ng:options. It renders the html nodes correctly but it doesn't displayed the value in the drop down.

http://jsfiddle.net/DNLt8/7/

@IgorMinar
Copy link
Contributor Author

0.9.19 is compatible with jquery 1.4.2, only 0.10.2+ is compatible with jquery 1.6.4

@respectTheCode
Copy link

That should be stated on the website somewhere. I was getting the impression that angular was buggy. I have downgraded jQuery to 1.6.2 and everything is working perfectly now. Thanks.

@cburgdorf
Copy link
Contributor

Wouldn't it be better to just always rely on the internal jQuery clone API? Or maybe introduce a global UseJQueryIfPesent flag that can be set to false.

@IgorMinar
Copy link
Contributor Author

Interesting suggestion, Christoph.

It's something we should look into. There are many benefits when using jquery for the dom manipulation (jquery is usually faster and does a better job than jqlite), but I agree that since we test only with one jquery version, it's possible that weird corner-cases can show up when angular uses incompatible jquery version.

I filed an RFE: #608

@IgorMinar
Copy link
Contributor Author

@respectTheCode did you mean to write 1.4.2? angular is likely not fully compatible with jquery 1.6.2.

@respectTheCode
Copy link

@IgorMinar No I have 1.6.2 and things seem to be working as expected now. What should I be using?

Edit: Just reread your comment from before. I will switch to 1.4.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants