Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Maximum stack exceeded / Too much recursion on Firefox #7648

Closed
pocesar opened this issue May 31, 2014 · 15 comments
Closed

Maximum stack exceeded / Too much recursion on Firefox #7648

pocesar opened this issue May 31, 2014 · 15 comments
Assignees

Comments

@pocesar
Copy link
Contributor

pocesar commented May 31, 2014

Testing the latest beta 10 on Firefox along with ui-router is giving a maximum call stack exceeded / too much recursion. Cross referecing the issue on angular-ui/ui-router#1104

I can't provide the minimum reproducible case because it's a really big project, but the problem began after changing ngRoute for ui-router

@Narretz
Copy link
Contributor

Narretz commented May 31, 2014

Could you try with previous beta versions and see at which one it works again? There are breaking changes in the beta, and this might have been caused by one.

@pocesar
Copy link
Contributor Author

pocesar commented May 31, 2014

tried all the betas, nothing changed. curious enough, it got solved when I changed jQuery 2.1.1 to 1.11.1... I'll need to post this issue there. Angular shouldn't break because of an external library.

@caitp
Copy link
Contributor

caitp commented May 31, 2014

@pocesar jQuery 2.x is not supported yet, there are problems with various things, including attaching data from the compile node to directive elements which were compiled with a template.

This will be fixed soon-ish (hopefully) /cc @mzgol

@pocesar
Copy link
Contributor Author

pocesar commented May 31, 2014

@caitp I see, would be good to have this in big letters somewhere :) since angular 1.3 dropped support for oldIE I thought it would go hand-in-hand with jQuery 2.x branch. I was using it happily without ever noticing problems until I changed to ui-router

@caitp
Copy link
Contributor

caitp commented May 31, 2014

It is actually mentioned in the documentation, but only in the tutorial apparently

Important: Be sure to use jQuery version 1.10.x. AngularJS does not yet support jQuery 2.x.

(https://docs.angularjs.org/tutorial/step_12)

@pocesar
Copy link
Contributor Author

pocesar commented May 31, 2014

all I could find was (https://docs.angularjs.org/misc/faq):

Does Angular use the jQuery library?

Yes, Angular can use jQuery if it's present in your app when the application is being bootstrapped. 
If jQuery is not present in your script path, Angular falls back to its own implementation of the 
subset of jQuery that we call jQLite.

Due to a change to use on()/off() rather than bind()/unbind(), Angular 1.2 only operates with
 jQuery 1.7.1 or above.

EDIT: I see, it's in the "12. Applying animations" which is a really trivial page for stating something this important notice. This should go on the download page instead or another "incompatibilities" dedicated page.

@Narretz
Copy link
Contributor

Narretz commented Jul 15, 2014

It's now in the FAQ that jquery 2.x is not supported: 46a53b2

@Narretz Narretz closed this as completed Jul 15, 2014
@mgol
Copy link
Member

mgol commented Aug 1, 2014

@pocesar The next Angular 1.3.0 beta will support jQuery 2.1 (and will not officially support older versions though they should work). The relevant commit: 9e7cb3c

The beta should be released in about a week. Before that happens, you can check if the issue still exists by trying the snapshot Angular version: https://code.angularjs.org/snapshot/angular.js

Don't use it in production, though, wait for a proper release.

If the problem exists, comment on the issue so that we can reopen it.

@pocesar
Copy link
Contributor Author

pocesar commented Aug 15, 2014

@mzgol just tested latest beta and jquery 2.1.1, still getting too much recursion (when using along with ui-router). need to fallback to jquery 1.x

@mgol
Copy link
Member

mgol commented Aug 15, 2014

I'll reopen this for investigation. jQuery 1.x is no longer supported so the advise from an earlier comment doesn't apply.

@mgol mgol reopened this Aug 15, 2014
@mgol mgol self-assigned this Aug 15, 2014
@mgol mgol modified the milestones: 1.3.0-beta.19, 1.3.0 Aug 15, 2014
@pocesar
Copy link
Contributor Author

pocesar commented Aug 15, 2014

@mzgol it seems to be a problem with firequery plugin, it now seems to work properly. if it happens again, I'll reopen

@rboughani
Copy link

I solved the problem by using angular-route 1.2.22 with AngularJS 1.4.8 (1.5.5)

@rboughani
Copy link

the problem is in angular-route.js

@mgol
Copy link
Member

mgol commented May 2, 2016

@darkmanAmazigh Don't mix different versions of Angular & angular-route, that's not supported and may break in unexpected ways.

@rboughani
Copy link

Yes i try, but for now there's a solution, and it work fine for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants